Dart2js option to dump info about compilation

sdk/lib/_internal/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
 const bool REPORT_EXCESS_RESOLUTION = false;
 
 /**
- * If true, dump the inferred types after compilation.
- */
-const bool DUMP_INFERRED_TYPES = false;
-
-/**
  * Contains backend-specific data that is used throughout the compilation of
  * one work item.
  */
 class ItemCompilationContext {
 }
 
 abstract class WorkItem {
   final ItemCompilationContext compilationContext;
   /**
    * Documentation wanted -- johnniwinther
@@ skipping 49 matching lines @@
 }
 
 abstract class Backend {
   final Compiler compiler;
   final ConstantSystem constantSystem;
 
   Backend(this.compiler,
           [ConstantSystem constantSystem = DART_CONSTANT_SYSTEM])
       : this.constantSystem = constantSystem;
 
+  /**
+   * Map each library to the size of the generated code for that library.
+   */
+  final CodeSizeCounter codeSizeCounter = new CodeSizeCounter();

[ahe, 2013/11/27 19:28:53]

It doesn't seem appropriate for the backend to expose a codeSizeCounter. This
appears to be a concern of dump_info.dart.

[sigurdm, 2013/11/29 10:39:37]

Done.

+
+  CodeBuffer emitCodeFor(Element element);

[ahe, 2013/11/27 19:28:53]

Please document this method.

[sigurdm, 2013/11/29 10:39:37]

Done.

+
   void initializeHelperClasses() {}
 
   void enqueueAllTopLevelFunctions(LibraryElement lib, Enqueuer world) {
     lib.forEachExport((Element e) {
       if (e.isFunction()) world.addToWorkList(e);
     });
   }
 
   void enqueueHelpers(ResolutionEnqueuer world, TreeElements elements);
   void codegen(CodegenWorkItem work);
 
   // The backend determines the native resolution enqueuer, with a no-op
   // default, so tools like dart2dart can ignore the native classes.
   native.NativeEnqueuer nativeResolutionEnqueuer(world) {
     return new native.NativeEnqueuer();
   }
   native.NativeEnqueuer nativeCodegenEnqueuer(world) {
     return new native.NativeEnqueuer();
   }
 
   void assembleProgram();
   List<CompilerTask> get tasks;
 
   void onResolutionComplete() {}
 
-  // TODO(ahe,karlklose): rename this?
-  void dumpInferredTypes() {}
+  Map collectDumpInfo() {

[ahe, 2013/11/27 19:28:53]

This seems like an odd fit for this functionality. Is there any way you can move
this into dump_info.dart.

[sigurdm, 2013/11/29 10:39:37]

Done.

+    List<LibraryElement> sortedLibraries = compiler.libraries.values.toList();
+    sortedLibraries.sort(

[karlklose, 2013/11/27 14:19:23]

You could also write it as follows: (we usually format closures like this when
given as arguments to reduce indentation)

sortedLibraries.sort((LibraryElement l1, LibraryElement l2) {
  if (l1.isPlatformLibrary != l2.isPlatformLibrary) {
    return l1.isPlatformLibrary ? 1 : -1;
  } else {
    return l1.getLibraryName().compareTo(l2.getLibraryName());
  }
});

[sigurdm, 2013/11/29 10:39:37]

Much better

+            (LibraryElement l1, LibraryElement l2) {
+              if (l1.isPlatformLibrary && !l2.isPlatformLibrary) {
+                return 1;
+              } else if (!l1.isPlatformLibrary && l2.isPlatformLibrary) {
+                return -1;
+              }
+              return l1.getLibraryName().
+                  compareTo(l2.getLibraryName());
+            });
+    List libraryInfos = [];

[karlklose, 2013/11/27 14:19:23]

'List' -> 'List<Map>', maybe even add the key and value type.  Also, add the
argument type to '[]', for example '<Map>[]', otherwise the object will be a
list of dynamic.

[sigurdm, 2013/11/29 10:39:37]

Problem is, that the value type is not fixed.
But ok.

+    for (LibraryElement library in sortedLibraries) {

[karlklose, 2013/11/27 14:19:23]

How about:

libraryInfos.addAll(sortedLibraries
    .map((library) => library.collectInferredTypes(compiler))
    .where((info) => info != null));

[sigurdm, 2013/11/29 10:39:37]

Nice

+      Map libraryInfo = library.collectInferredTypes(compiler);
+      if (libraryInfo != null) {
+        libraryInfos.add(libraryInfo);
+      }
+    }
+    Map info = {
+        "compilation duration" : compiler.totalCompileTime.elapsedTicks,

[karlklose, 2013/11/27 14:19:23]

Remove the space between the map key and ':'.

[sigurdm, 2013/11/29 10:39:37]

Done.

+        // TODO (sigurdm) Also count the size of deferred code
+        "generated size" : compiler.assembledCode.length,
+        "libraries" : libraryInfos,
+        "compilation time" : new DateTime.now().toString()
+    };
+    if (commandline.BUILD_ID != null) {
+      info["dart2js version"] = commandline.BUILD_ID.toString();
+    }
+    return info;
+  }
+
+  void dumpInfo() {
+    Map info = collectDumpInfo();
+    StringBuffer buffer = new StringBuffer();
+    dumpInfoHtml(info, buffer);
+    compiler.outputProvider('', 'info.html')
+      ..add(buffer.toString())
+      ..close();
+  }
 
   ItemCompilationContext createItemCompilationContext() {
     return new ItemCompilationContext();
   }
 
   bool classNeedsRti(ClassElement cls);
   bool methodNeedsRti(FunctionElement function);
 
 
   /// Called during codegen when [constant] has been used.
@@ skipping 235 matching lines @@
    * associated with a particular element.
    */
   final TreeElements globalDependencies = new TreeElementMapping(null);
 
   final bool enableMinification;
   final bool enableTypeAssertions;
   final bool enableUserAssertions;
   final bool trustTypeAnnotations;
   final bool enableConcreteTypeInference;
   final bool disableTypeInferenceFlag;
+  final bool dumpInfo;
 
   /**
    * The maximum size of a concrete type before it widens to dynamic during
    * concrete type inference.
    */
   final int maxConcreteTypeSize;
   final bool analyzeAllFlag;
   final bool analyzeOnly;
   /**
    * If true, skip analysis of method bodies and field initializers. Implies
@@ skipping 241 matching lines @@
             bool generateSourceMap: true,
             this.analyzeAllFlag: false,
             bool analyzeOnly: false,
             bool analyzeSignaturesOnly: false,
             this.preserveComments: false,
             this.verbose: false,
             this.sourceMapUri: null,
             this.buildId: UNDETERMINED_BUILD_ID,
             this.globalJsName: r'$',
             this.terseDiagnostics: false,
+            this.dumpInfo: false,
             outputProvider,
             List<String> strips: const []})
       : this.analyzeOnly = analyzeOnly || analyzeSignaturesOnly,
         this.analyzeSignaturesOnly = analyzeSignaturesOnly,
         this.outputProvider = (outputProvider == null)
             ? NullSink.outputProvider
             : outputProvider {
     world = new World(this);
 
     closureMapping.ClosureNamer closureNamer;
@@ skipping 487 matching lines @@
       libraries.forEach((_, lib) => fullyEnqueueLibrary(lib,
           enqueuer.codegen));
     }
     processQueue(enqueuer.codegen, main);
     enqueuer.codegen.logSummary(log);
 
     if (compilationFailed) return;
 
     backend.assembleProgram();
 
+    if (dumpInfo) {
+      backend.dumpInfo();

[ahe, 2013/11/27 19:28:53]

This should be its own task. Then we can see how long it takes.

[sigurdm, 2013/11/29 10:39:37]

Done.

+    }
+
     checkQueues();
 
     if (compilationFailed) {
       assembledCode = null; // Signals failure.
     }
   }
 
   void fullyEnqueueLibrary(LibraryElement library, Enqueuer world) {
     void enqueueAll(Element element) {
       fullyEnqueueTopLevelElement(element, world);
@@ skipping 39 matching lines @@
       }
       world.addToWorkList(main);
     }
     progress.reset();
     world.forEach((WorkItem work) {
       withCurrentElement(work.element, () => work.run(this, world));
     });
     world.queueIsClosed = true;
     if (compilationFailed) return;
     assert(world.checkNoEnqueuedInvokedInstanceMethods());
-    if (DUMP_INFERRED_TYPES && phase == PHASE_COMPILING) {
-      backend.dumpInferredTypes();
-    }
   }
 
   /**
    * Perform various checks of the queues. This includes checking that
    * the queues are empty (nothing was added after we stopped
    * processing the queues). Also compute the number of methods that
    * were resolved, but not compiled (aka excess resolution).
    */
   checkQueues() {
     for (Enqueuer world in [enqueuer.resolution, enqueuer.codegen]) {
@@ skipping 445 matching lines @@
 
   void close() {}
 
   toString() => name;
 
   /// Convenience method for getting an [api.CompilerOutputProvider].
   static NullSink outputProvider(String name, String extension) {
     return new NullSink('$name.$extension');
   }
 }