Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 907103002: NaCl docs: fix clumsy sentence (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl docs: fix clumsy sentence R= binji@chromium.org BUG=none Committed: https://crrev.com/e635757699fe991b6aef2a0fc21e1f0b3ac691f6 Cr-Commit-Position: refs/heads/master@{#315420}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M native_client_sdk/doc_generated/faq.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
JF
5 years, 10 months ago (2015-02-09 19:27:01 UTC) #1
binji
lgtm https://codereview.chromium.org/907103002/diff/1/native_client_sdk/src/doc/faq.rst File native_client_sdk/src/doc/faq.rst (right): https://codereview.chromium.org/907103002/diff/1/native_client_sdk/src/doc/faq.rst#newcode506 native_client_sdk/src/doc/faq.rst:506: use new ``.pexe`` files that your existing ``.pexe`` ...
5 years, 10 months ago (2015-02-09 21:28:46 UTC) #2
JF
On 2015/02/09 21:28:46, binji wrote: > lgtm > > https://codereview.chromium.org/907103002/diff/1/native_client_sdk/src/doc/faq.rst > File native_client_sdk/src/doc/faq.rst (right): > ...
5 years, 10 months ago (2015-02-09 22:28:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907103002/1
5 years, 10 months ago (2015-02-09 22:30:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 22:50:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 22:53:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e635757699fe991b6aef2a0fc21e1f0b3ac691f6
Cr-Commit-Position: refs/heads/master@{#315420}

Powered by Google App Engine
This is Rietveld 408576698