Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 907073003: [Android] Update permanent node number DCHECK. (Closed)

Created:
5 years, 10 months ago by Kibeom Kim (inactive)
Modified:
5 years, 10 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews, Ian Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Update permanent node number DCHECK. Now the root node has one more child, "Parent suggestions" so adjust the DCHECK accordingly. BUG=443606 Committed: https://crrev.com/9f9debb89f71b3f769054c0d25b4145bce2ed604 Cr-Commit-Position: refs/heads/master@{#315403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Kibeom Kim (inactive)
5 years, 10 months ago (2015-02-09 20:04:50 UTC) #2
newt (away)
lgtm
5 years, 10 months ago (2015-02-09 21:25:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907073003/1
5 years, 10 months ago (2015-02-09 21:28:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 22:03:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f9debb89f71b3f769054c0d25b4145bce2ed604 Cr-Commit-Position: refs/heads/master@{#315403}
5 years, 10 months ago (2015-02-09 22:04:11 UTC) #7
Marc Treib
5 years, 10 months ago (2015-02-10 08:56:34 UTC) #8
Message was sent while issue was closed.
Whoops, sorry about that, and thanks for fixing my bug!

Powered by Google App Engine
This is Rietveld 408576698