Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 907063002: Remove friend declarations from CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Another approach Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/CSSPropertyParser.h
diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h
index fddc2f96a68be26f647eaf1c114e16fbb7a797b6..6ba365c0ca3d938c93623a668dbc14c0c113318a 100644
--- a/Source/core/css/parser/CSSPropertyParser.h
+++ b/Source/core/css/parser/CSSPropertyParser.h
@@ -31,6 +31,7 @@
namespace blink {
+class BorderImageParseContext;
class CSSBorderImageSliceValue;
class CSSBasicShape;
class CSSBasicShapeInset;
@@ -352,6 +353,12 @@ private:
int colorIntFromValue(CSSParserValue*);
bool isCalculation(CSSParserValue*);
+ bool buildBorderImageParseContext(CSSPropertyID, BorderImageParseContext&);
+
+ bool parseDeprecatedGradientColorStop(CSSParserValue*, CSSGradientColorStop&);
+
+ void commitBorderImageProperty(CSSPropertyID, PassRefPtrWillBeRawPtr<CSSValue>, bool important);
+
private:
// Inputs:
CSSParserValueList* m_valueList;
@@ -367,16 +374,6 @@ private:
CSSPropertyID m_currentShorthand;
bool m_implicitShorthand;
RefPtrWillBeMember<CSSCalcValue> m_parsedCalculation;
-
- // FIXME: There is probably a small set of APIs we could expose for these
- // classes w/o needing to make them friends.
- friend class ShadowParseContext;
- friend class BorderImageParseContext;
- friend class BorderImageSliceParseContext;
- friend class BorderImageQuadParseContext;
- friend class TransformOperationInfo;
- friend bool parseDeprecatedGradientColorStop(CSSPropertyParser*, CSSParserValue*, CSSGradientColorStop&);
- friend PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseGradientColorOrKeyword(CSSPropertyParser*, CSSParserValue*);
};
CSSPropertyID cssPropertyID(const CSSParserString&);
« no previous file with comments | « no previous file | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698