Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 907033002: Revert of Add debug information for crbug.com/289715 (Closed)

Created:
5 years, 10 months ago by battre
Modified:
5 years, 10 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add debug information for crbug.com/289715 (patchset #5 id:80001 of https://codereview.chromium.org/810883007/) Reason for revert: Remove debugging information that was collected for crbug.com/289715 Original issue's description: > Add debug information for crbug.com/289715 > > Add temporary debugging information to determine whether a callback happens > after the targeted URLRequestHttpJob was already deleted or whether a callback > happens after its transaction was deleted. > > BUG=289715 > > Committed: https://crrev.com/aec005dce78bc2c2513f4e49343b8baad751a852 > Cr-Commit-Position: refs/heads/master@{#310822} TBR=mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=289715 Committed: https://crrev.com/652b6d56d7a585e52ee8c7a8b5aea06b804bf02b Cr-Commit-Position: refs/heads/master@{#315298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M net/url_request/url_request_http_job.h View 2 chunks +0 lines, -13 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 5 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Revert of Add debug information for crbug.com/289715
5 years, 10 months ago (2015-02-09 15:03:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907033002/1
5 years, 10 months ago (2015-02-09 15:04:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 15:05:07 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:05:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/652b6d56d7a585e52ee8c7a8b5aea06b804bf02b
Cr-Commit-Position: refs/heads/master@{#315298}

Powered by Google App Engine
This is Rietveld 408576698