Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 907013002: Add payload checksum to code cache data. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add payload checksum to code cache data. R=jochen@chromium.org BUG=chromium:441896 LOG=N Committed: https://crrev.com/7819c593e8d7102922d00578ba4b4c8b69a6dce7 Cr-Commit-Position: refs/heads/master@{#26529}

Patch Set 1 #

Total comments: 3

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -30 lines) Patch
M src/serialize.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/serialize.cc View 1 4 chunks +46 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +32 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years, 10 months ago (2015-02-09 13:41:48 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/907013002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/907013002/diff/1/src/serialize.cc#newcode2491 src/serialize.cc:2491: Checksum(Vector<const byte> payload) { explicit https://codereview.chromium.org/907013002/diff/1/src/serialize.cc#newcode2519 src/serialize.cc:2519: }; ...
5 years, 10 months ago (2015-02-09 14:11:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907013002/20001
5 years, 10 months ago (2015-02-09 14:23:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 14:49:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 14:49:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7819c593e8d7102922d00578ba4b4c8b69a6dce7
Cr-Commit-Position: refs/heads/master@{#26529}

Powered by Google App Engine
This is Rietveld 408576698