Issue 907003003: Push API: Remove deprecated lastAppId storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 907003003: Push API: Remove deprecated lastAppId storage. (Closed)

Created:
5 years, 10 months ago by johnme

Modified:
5 years, 10 months ago

Reviewers:
fgorski

CC:
chromium-reviews, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Push API: Remove deprecated lastAppId storage. This was just a hacky workaround whilst GCM didn't send us subtypes for incoming messages. Now that it does, we don't need it any more (and it might cause false positives during testing). BUG=350383 Committed: https://crrev.com/eaa83600022fc132b288fc2a41bdc8bf1eeca5c2 Cr-Commit-Position: refs/heads/master@{#315358}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -45 lines)			Patch
	M	components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java	View		7 chunks	+5 lines, -29 lines	0 comments	Download
	M	components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMListener.java	View		4 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907003003/1

5 years, 10 months ago (2015-02-09 18:12:16 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 19:05:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eaa83600022fc132b288fc2a41bdc8bf1eeca5c2
Cr-Commit-Position: refs/heads/master@{#315358}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages