components/password_manager/core/browser/password_store_sync.h - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Unified Diff: components/password_manager/core/browser/password_store_sync.h

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.cc ('K') | « components/password_manager/core/browser/login_database_win.cc ('k') | components/password_manager/core/browser/test_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_sync.h

diff --git a/components/password_manager/core/browser/password_store_sync.h b/components/password_manager/core/browser/password_store_sync.h

index bed837a3752ce3a11754bbf252e508450ab4817b..33aa2170da4b1204af7d539cd46daeccb4d44d9a 100644

--- a/components/password_manager/core/browser/password_store_sync.h

+++ b/components/password_manager/core/browser/password_store_sync.h

@@ -16,11 +16,13 @@ namespace password_manager {

// thread only.

class PasswordStoreSync {

public:

- // Finds all non-blacklist PasswordForms, and fills the vector.

+ // Overwrites |forms| with all stored non-blacklisted credentials. On success,

+ // returns true, otherwise returns false and erases |forms|.

engedy 2015/02/25 15:17:49 Nit: s/,/;/

vabr (Chromium) 2015/03/09 10:56:19 Acknowledged, but rewrote completely.

engedy 2015/03/09 13:33:17 Acknowledged.

virtual bool FillAutofillableLogins(

engedy 2015/02/25 15:17:49 We also need to update the implementation in Passw

vabr (Chromium) 2015/03/09 10:56:19 Done.

ScopedVector<autofill::PasswordForm>* forms) = 0;

- // Finds all blacklist PasswordForms, and fills the vector.

+ // Overwrites |forms| with all stored blacklisted credentials. On success,

+ // returns true, otherwise returns false and erases |forms|.

engedy 2015/02/25 15:17:49 Nit: s/,/;/

vabr (Chromium) 2015/03/09 10:56:19 Acknowledged, but rewrote completely.

engedy 2015/03/09 13:33:17 Acknowledged.

virtual bool FillBlacklistLogins(

ScopedVector<autofill::PasswordForm>* forms) = 0;