chrome/browser/password_manager/password_store_mac.cc - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_libsecret.cc ('K') | « chrome/browser/password_manager/native_backend_libsecret_unittest.cc ('k') | chrome/browser/password_manager/password_store_x.h » ('j') | chrome/browser/password_manager/password_store_x.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.cc

diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc

index 31c0d2b43d67d07a11c33b539ebc98d31deac799..fe9bde3c771eceb4681f30bcdc6723fc019e7c8e 100644

--- a/chrome/browser/password_manager/password_store_mac.cc

+++ b/chrome/browser/password_manager/password_store_mac.cc

@@ -1125,6 +1125,7 @@ void PasswordStoreMac::GetAutofillableLoginsImpl(

bool PasswordStoreMac::FillAutofillableLogins(

ScopedVector<autofill::PasswordForm>* forms) {

DCHECK(thread_->message_loop() == base::MessageLoop::current());

+ forms->clear();

ScopedVector<PasswordForm> database_forms;

if (!login_metadata_db_ ||