Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index 16b1e3ebf9c806a3774dd65398c4eacb26496740..0ee38287a15216913f9e9d50cad43c22443fb530 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -1034,38 +1034,6 @@ TEST_F(NativeBackendGnomeTest, AddDuplicateLogin) {
CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
}
-TEST_F(NativeBackendGnomeTest, ListLoginsAppends) {
- NativeBackendGnome backend(42);
- backend.Init();
-
- BrowserThread::PostTask(
- BrowserThread::DB, FROM_HERE,
- base::Bind(base::IgnoreResult(&NativeBackendGnome::AddLogin),
- base::Unretained(&backend), form_google_));
-
- // Send the same request twice with the same list both times.
- ScopedVector<autofill::PasswordForm> form_list;
- BrowserThread::PostTask(
- BrowserThread::DB, FROM_HERE,
- base::Bind(
- base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
- base::Unretained(&backend), &form_list));
- BrowserThread::PostTask(
- BrowserThread::DB, FROM_HERE,
- base::Bind(
- base::IgnoreResult(&NativeBackendGnome::GetAutofillableLogins),
- base::Unretained(&backend), &form_list));
-
- RunBothThreads();
-
- // Quick check that we got two results back.
- EXPECT_EQ(2u, form_list.size());
-
- EXPECT_EQ(1u, mock_keyring_items.size());
- if (mock_keyring_items.size() > 0)
- CheckMockKeyringItem(&mock_keyring_items[0], form_google_, "chrome-42");
-}
-
TEST_F(NativeBackendGnomeTest, AndroidCredentials) {
NativeBackendGnome backend(42);
backend.Init();

Powered by Google App Engine
This is Rietveld 408576698