PasswordStore: Clean up expectations about rewriting vectors of forms

chrome/browser/password_manager/password_store_x.h

Index: chrome/browser/password_manager/password_store_x.h
diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h
index 7ae07eda62ad6e242c3c2508ceb3d31a697d4a76..96ff38470b011476e44bd907b3231cbe3d9f106e 100644
--- a/chrome/browser/password_manager/password_store_x.h
+++ b/chrome/browser/password_manager/password_store_x.h
@@ -58,12 +58,16 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
         base::Time delete_end,
         password_manager::PasswordStoreChangeList* changes) = 0;
 
+    // The three methods below overwrite |forms| with all stored credentials
+    // matching |form|, all stored non-blacklisted credentials, and all stored
+    // blacklisted credentials, respectively. On success, they return true.
     virtual bool GetLogins(const autofill::PasswordForm& form,
-                           ScopedVector<autofill::PasswordForm>* forms) = 0;
+                           ScopedVector<autofill::PasswordForm>* forms)
+        WARN_UNUSED_RESULT = 0;
     virtual bool GetAutofillableLogins(
-        ScopedVector<autofill::PasswordForm>* forms) = 0;
-    virtual bool GetBlacklistLogins(
-        ScopedVector<autofill::PasswordForm>* forms) = 0;
+        ScopedVector<autofill::PasswordForm>* forms) WARN_UNUSED_RESULT = 0;
+    virtual bool GetBlacklistLogins(ScopedVector<autofill::PasswordForm>* forms)
+        WARN_UNUSED_RESULT = 0;
   };
 
   // Takes ownership of |login_db| and |backend|. |backend| may be NULL in which