PasswordStore: Clean up expectations about rewriting vectors of forms

chrome/browser/password_manager/password_store_x_unittest.cc

Index: chrome/browser/password_manager/password_store_x_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index 737353c320e838aadbd6c815d944910fc7a3474e..5c37ba32ecd8ca6e84f3a582d312a4aee41436bd 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -80,17 +80,34 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
     return false;
   }
 
+  // Inserts some unexpected values into |forms|. Useful as a landmine to check
+  // whether results of failed Get*Logins calls get ignored.
+  static InsertTrashForms(ScopedVector<autofill::PasswordForm>* forms) {
+    PasswordForm trash;
+    trash.username_element = base::ASCIIToUTF16("trash u. element");
+    trash.username_value = base::ASCIIToUTF16("trash u. value");
+    trash.password_element = base::ASCIIToUTF16("trash p. element");
+    trash.password_value = base::ASCIIToUTF16("trash p. value");
+    for (size_t i = 0; i < 3; ++i) {
+      trash.origin = base::StringPrintf("http://trash%zu.com", i);
+      forms->push_back(new PasswordForm(trash));
+    }
+  }
+
   bool GetLogins(const PasswordForm& form,
                  ScopedVector<autofill::PasswordForm>* forms) override {
+    InsertTrashForms(forms);
     return false;
   }
 
   bool GetAutofillableLogins(
       ScopedVector<autofill::PasswordForm>* forms) override {
+    InsertTrashForms(forms);
     return false;
   }
   bool GetBlacklistLogins(
       ScopedVector<autofill::PasswordForm>* forms) override {
+    InsertTrashForms(forms);
     return false;
   }
 };
@@ -207,9 +224,9 @@ void LoginDatabaseQueryCallback(password_manager::LoginDatabase* login_db,
                                 MockLoginDatabaseReturn* mock_return) {
   ScopedVector<autofill::PasswordForm> forms;
   if (autofillable)
-    login_db->GetAutofillableLogins(&forms);
+    EXPECT_TRUE(login_db->GetAutofillableLogins(&forms));
   else
-    login_db->GetBlacklistLogins(&forms);
+    EXPECT_TRUE(login_db->GetBlacklistLogins(&forms));
   mock_return->OnLoginDatabaseQueryDone(forms.get());
 }