components/password_manager/core/browser/password_store_sync.h - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_sync.h

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_gnome_x.cc ('K') | « components/password_manager/core/browser/login_database_win.cc ('k') | components/password_manager/core/browser/test_password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_sync.h

diff --git a/components/password_manager/core/browser/password_store_sync.h b/components/password_manager/core/browser/password_store_sync.h

index bed837a3752ce3a11754bbf252e508450ab4817b..33aa2170da4b1204af7d539cd46daeccb4d44d9a 100644

--- a/components/password_manager/core/browser/password_store_sync.h

+++ b/components/password_manager/core/browser/password_store_sync.h

@@ -16,11 +16,13 @@ namespace password_manager {

// thread only.

class PasswordStoreSync {

public:

- // Finds all non-blacklist PasswordForms, and fills the vector.

+ // Overwrites |forms| with all stored non-blacklisted credentials. On success,

+ // returns true, otherwise returns false and erases |forms|.

virtual bool FillAutofillableLogins(

ScopedVector<autofill::PasswordForm>* forms) = 0;

- // Finds all blacklist PasswordForms, and fills the vector.

+ // Overwrites |forms| with all stored blacklisted credentials. On success,

+ // returns true, otherwise returns false and erases |forms|.

virtual bool FillBlacklistLogins(

ScopedVector<autofill::PasswordForm>* forms) = 0;