chrome/browser/password_manager/password_store_x.h - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_gnome_x.cc ('K') | « chrome/browser/password_manager/password_store_mac.cc ('k') | components/password_manager/core/browser/login_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x.h

diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h

index d863cdacd1124d2b0b240789795d582e59cba5e4..0d10a68f9a1c04c56eed0dcc4566b739f99d2bef 100644

--- a/chrome/browser/password_manager/password_store_x.h

+++ b/chrome/browser/password_manager/password_store_x.h

@@ -58,6 +58,10 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {

base::Time delete_end,

password_manager::PasswordStoreChangeList* changes) = 0;

+ // The three methods below overwrite |forms| with all stored credentials

+ // matching |form|, all stored non-blacklisted credentials, and all stored

+ // blacklisted credentials, respectively. On success, they return true,

+ // otherwise they return false and erase |forms|.

virtual bool GetLogins(const autofill::PasswordForm& form,

ScopedVector<autofill::PasswordForm>* forms) = 0;

virtual bool GetAutofillableLogins(