Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7269)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.h

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x.h
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.h b/chrome/browser/password_manager/native_backend_gnome_x.h
index 438917a5e009e69a0d92fc5802e092d0db41d404..6108771b9b1521be87405ddbed57da16ee724f9f 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.h
+++ b/chrome/browser/password_manager/native_backend_gnome_x.h
@@ -120,7 +120,9 @@ class NativeBackendGnome : public PasswordStoreX::NativeBackend,
// Adds a login form without checking for one to replace first.
bool RawAddLogin(const autofill::PasswordForm& form);
- // Reads PasswordForms from the keyring with the given autofillability state.
+ // Overwrites |forms| with blacklisted or autofillable, depending on
+ // |autofillable| being false or true, credentials from the keyring. In case
+ // of failures returns false and erases |forms|, otherwise returns true.
bool GetLoginsList(bool autofillable,
ScopedVector<autofill::PasswordForm>* forms);

Powered by Google App Engine
This is Rietveld 408576698