Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FillMatchingLogins + a typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc
index 737353c320e838aadbd6c815d944910fc7a3474e..ce8f307b64e9a949d2a3982af3917eb8c0f46c23 100644
--- a/chrome/browser/password_manager/password_store_x_unittest.cc
+++ b/chrome/browser/password_manager/password_store_x_unittest.cc
@@ -82,15 +82,18 @@ class FailingBackend : public PasswordStoreX::NativeBackend {
bool GetLogins(const PasswordForm& form,
ScopedVector<autofill::PasswordForm>* forms) override {
+ forms->clear();
return false;
}
bool GetAutofillableLogins(
ScopedVector<autofill::PasswordForm>* forms) override {
+ forms->clear();
return false;
}
bool GetBlacklistLogins(
ScopedVector<autofill::PasswordForm>* forms) override {
+ forms->clear();
return false;
}
};
@@ -207,9 +210,9 @@ void LoginDatabaseQueryCallback(password_manager::LoginDatabase* login_db,
MockLoginDatabaseReturn* mock_return) {
ScopedVector<autofill::PasswordForm> forms;
if (autofillable)
- login_db->GetAutofillableLogins(&forms);
+ EXPECT_TRUE(login_db->GetAutofillableLogins(&forms));
else
- login_db->GetBlacklistLogins(&forms);
+ EXPECT_TRUE(login_db->GetBlacklistLogins(&forms));
mock_return->OnLoginDatabaseQueryDone(forms.get());
}

Powered by Google App Engine
This is Rietveld 408576698