Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FillMatchingLogins + a typo Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
index c0687dedba0c4ced1aa27e89f970ca3fa7b4e94d..95c4c8c0e7709ad691a690786f0bc73cdcbca3c4 100644
--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
@@ -789,26 +789,6 @@ TEST_F(NativeBackendLibsecretTest, AddDuplicateLogin) {
"chrome-42");
}
-TEST_F(NativeBackendLibsecretTest, ListLoginsAppends) {
- NativeBackendLibsecret backend(42);
-
- backend.AddLogin(form_google_);
-
- // Send the same request twice with the same list both times.
- ScopedVector<autofill::PasswordForm> form_list;
- backend.GetAutofillableLogins(&form_list);
- backend.GetAutofillableLogins(&form_list);
-
- // Quick check that we got two results back.
- EXPECT_EQ(2u, form_list.size());
- form_list.clear();
-
- EXPECT_EQ(1u, global_mock_libsecret_items->size());
- if (!global_mock_libsecret_items->empty())
- CheckMockSecretItem((*global_mock_libsecret_items)[0], form_google_,
- "chrome-42");
-}
-
TEST_F(NativeBackendLibsecretTest, AndroidCredentials) {
NativeBackendLibsecret backend(42);
backend.Init();
@@ -831,7 +811,6 @@ TEST_F(NativeBackendLibsecretTest, AndroidCredentials) {
EXPECT_EQ(saved_android_form, *form_list[0]);
}
-
TEST_F(NativeBackendLibsecretTest, RemoveLoginsCreatedBetween) {
CheckRemoveLoginsBetween(CREATED);
}

Powered by Google App Engine
This is Rietveld 408576698