PasswordStore: Clean up expectations about rewriting vectors of forms

chrome/browser/password_manager/native_backend_gnome_x.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
 
 // libgnome-keyring has been deprecated in favor of libsecret.
 // See: https://mail.gnome.org/archives/commits-list/2013-October/msg08876.html
 //
 // The define below turns off the deprecations, in order to avoid build
 // failures with Gnome 3.12. When we move to libsecret, the define can be
 // removed, together with the include below it.
 //
 // The porting is tracked in http://crbug.com/355223
 #define GNOME_KEYRING_DEPRECATED
 #define GNOME_KEYRING_DEPRECATED_FOR(x)
 #include <gnome-keyring.h>
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/compiler_specific.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/password_store_x.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace autofill {
 struct PasswordForm;
 }
 
@@ skipping 80 matching lines @@
 
  private:
   enum TimestampToCompare {
     CREATION_TIMESTAMP,
     SYNC_TIMESTAMP,
   };
 
   // Adds a login form without checking for one to replace first.
   bool RawAddLogin(const autofill::PasswordForm& form);
 
-  // Reads PasswordForms from the keyring with the given autofillability state.
+  // Retrieves all autofillable or all blacklisted credentials (depending on
+  // |autofillable|) from the keyring into |forms|, overwriting the original
+  // contents of |forms|. Returns true on success.
   bool GetLoginsList(bool autofillable,
-                     ScopedVector<autofill::PasswordForm>* forms);
+                     ScopedVector<autofill::PasswordForm>* forms)
+      WARN_UNUSED_RESULT;
 
   // Helper for GetLoginsCreatedBetween().
-  bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms);
+  bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms)
+      WARN_UNUSED_RESULT;
 
   // Retrieves password created/synced in the time interval. Returns |true| if
   // the operation succeeded.
   bool GetLoginsBetween(base::Time get_begin,
                         base::Time get_end,
                         TimestampToCompare date_to_compare,
-                        ScopedVector<autofill::PasswordForm>* forms);
+                        ScopedVector<autofill::PasswordForm>* forms)
+      WARN_UNUSED_RESULT;
 
   // Removes password created/synced in the time interval. Returns |true| if the
   // operation succeeded. |changes| will contain the changes applied.
   bool RemoveLoginsBetween(base::Time get_begin,
                            base::Time get_end,
                            TimestampToCompare date_to_compare,
                            password_manager::PasswordStoreChangeList* changes);
 
-  // Generates a profile-specific app string based on profile_id_.
-  std::string GetProfileSpecificAppString() const;
-
   // The local profile id, used to generate the app string.
   const LocalProfileId profile_id_;
 
   // The app string, possibly based on the local profile id.
   std::string app_string_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeBackendGnome);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_