Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 906963002: layout tests: Fixes property enumeration tests. (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

layout tests: Fixes property enumeration tests. In for (prop in obj), there is no guarantee about the order of property list. We should not rely on a specific order of listing. Fixes tests by sorting properties. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M LayoutTests/fast/dom/htmlallcollection-enumerated-properties.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/htmlcollection-enumerated-properties.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/htmlformcontrolscollection-enumerated-properties.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/htmloptionscollection-enumerated-properties.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
Could you review this CL?
5 years, 10 months ago (2015-02-09 09:53:37 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-09 11:22:13 UTC) #3
jsbell
lgtm The order should be stable, though implementation defined. (In Chrome/V8 it would be own ...
5 years, 10 months ago (2015-02-09 17:43:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906963002/1
5 years, 10 months ago (2015-02-10 01:59:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 03:24:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189859

Powered by Google App Engine
This is Rietveld 408576698