Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 906923003: Fix fonts not loading in PDFs that don't embed them. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix fonts not loading in PDFs that don't embed them. This regressed in https://codereview.chromium.org/897563002/. I also fixed the ChromeContentUtilityClient::PreSandboxStartup() code as well since it was incorrect. BUG=456623 Committed: https://crrev.com/44b322fe7f195b17f494fd8b042cdc88457b96e6 Cr-Commit-Position: refs/heads/master@{#315364}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/child/pdf_child_init.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
5 years, 10 months ago (2015-02-09 05:53:30 UTC) #2
raymes
Thanks John! lgtm (though if there is someone better to review please add them!) It ...
5 years, 10 months ago (2015-02-09 06:29:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906923003/20001
5 years, 10 months ago (2015-02-09 19:39:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 19:42:50 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 19:44:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44b322fe7f195b17f494fd8b042cdc88457b96e6
Cr-Commit-Position: refs/heads/master@{#315364}

Powered by Google App Engine
This is Rietveld 408576698