Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 906883003: Update WPR file of ServiceWorker telemetry test. (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
Reviewers:
falken, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WPR file of ServiceWorker telemetry test. service_worker_037.wpr was recorded before we introduced the script path restriction (crbug.com/423983). This registration code in this record always fails. navigator.serviceWorker.register('/trained-to-thrill/static/js/sw.js', { scope: '/trained-to-thrill/' }) So we have to update the WPR file I recorded service_worker_038.wpr using this command. ./tools/perf/record_wpr --browser=exact --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker_page_set BUG=433943 TEST=./tools/perf/run_benchmark --output-format=chartjson --upload-results --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker Committed: https://crrev.com/465fdc5272886d0d75a3d9164e3ab3f639defd3e Cr-Commit-Position: refs/heads/master@{#317747}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/perf/page_sets/data/service_worker.json View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/service_worker_038.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
horo
falken@ Could you please review this?
5 years, 10 months ago (2015-02-16 05:25:03 UTC) #3
falken
I don't get it. All I see is a SHA1 change. Is there a file ...
5 years, 10 months ago (2015-02-16 06:11:55 UTC) #4
horo
On 2015/02/16 06:11:55, falken wrote: > I don't get it. All I see is a ...
5 years, 10 months ago (2015-02-16 07:28:01 UTC) #5
falken
I guess there's nothing I can check from rietveld but assuming the tests are passing ...
5 years, 10 months ago (2015-02-16 08:07:17 UTC) #6
horo
nednguyen@ Could you please review this?
5 years, 10 months ago (2015-02-16 08:11:46 UTC) #8
nednguyen
lgtm
5 years, 10 months ago (2015-02-16 16:01:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906883003/20001
5 years, 10 months ago (2015-02-24 01:56:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-24 02:52:45 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 02:53:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465fdc5272886d0d75a3d9164e3ab3f639defd3e
Cr-Commit-Position: refs/heads/master@{#317747}

Powered by Google App Engine
This is Rietveld 408576698