Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 906753002: Revert of Added MockPresentationClient to use in layout tests. (Closed)

Created:
5 years, 10 months ago by dsinclair
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added MockPresentationClient to use in layout tests. (patchset #1 id:1 of https://codereview.chromium.org/905823004/) Reason for revert: This is causing layout failures on the blink bots. They're crashing with the following assertion: STDERR: [17800:1287:0207/062834:4514258387182:FATAL:mock_presentation_client.cc(34)] Check failed: controller_ != controller && (!controller || !controller_). Original issue's description: > Added MockPresentationClient to use in layout tests. > > Blink change with the test follows: https://codereview.chromium.org/906673002/ > > BUG=412331 > > Committed: https://crrev.com/49a225f6ecb52b805a99d55e9e37ed7e21ef7c1b > Cr-Commit-Position: refs/heads/master@{#315204} TBR=mkwst@chromium.org,peter@chromium.org,avayvod@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=412331 Committed: https://crrev.com/2b69cdc15e729f5566cf51d81a155607ff6e95f1 Cr-Commit-Position: refs/heads/master@{#315208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -131 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_client.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/shell/renderer/test_runner/mock_presentation_client.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dsinclair
Created Revert of Added MockPresentationClient to use in layout tests.
5 years, 10 months ago (2015-02-07 14:44:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906753002/1
5 years, 10 months ago (2015-02-07 14:45:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 14:45:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b69cdc15e729f5566cf51d81a155607ff6e95f1 Cr-Commit-Position: refs/heads/master@{#315208}
5 years, 10 months ago (2015-02-07 14:46:39 UTC) #4
dsinclair
5 years, 10 months ago (2015-02-07 14:47:07 UTC) #5
Message was sent while issue was closed.
On 2015/02/07 at 14:45:28, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/906753002/1


I saw the crashes on mac_blink_rel, linux_blink_rel and linux_blink_dbg before
reverting. An example run is:
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41892

Powered by Google App Engine
This is Rietveld 408576698