Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 906743002: X87: fix performance regression on intel call api stubs (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: fix performance regression on intel call api stubs port b18ad510798d3a5e75f6b68656d8f8826571e782 (r26291) original commit message: additionally, make the interface match the JSFunction interface BUG= Committed: https://crrev.com/db379e19c82ef263f660aeb6f6683192822c19a4 Cr-Commit-Position: refs/heads/master@{#26503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +16 lines, -9 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-07 08:06:21 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-07 08:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906743002/1
5 years, 10 months ago (2015-02-07 08:07:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 08:43:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 08:44:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db379e19c82ef263f660aeb6f6683192822c19a4
Cr-Commit-Position: refs/heads/master@{#26503}

Powered by Google App Engine
This is Rietveld 408576698