Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 906713002: Extract invoke-main stub generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase and remove whitespace. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index 25d4b43ff58ea22c11de73b98afa48a160209267..f31beb7d42c43075bbbd4eda4c8bc0e422c90192 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -914,32 +914,8 @@ class OldEmitter implements Emitter {
backend.rti.getFunctionThatReturnsNullName]);
}
- /// Returns the code equivalent to:
- /// `function(args) { $.startRootIsolate(X.main$closure(), args); }`
- jsAst.Expression buildIsolateSetupClosure(Element appMain,
- Element isolateMain) {
- jsAst.Expression mainAccess = isolateStaticClosureAccess(appMain);
- // Since we pass the closurized version of the main method to
- // the isolate method, we must make sure that it exists.
- return js('function(a){ #(#, a); }',
- [backend.emitter.staticFunctionAccess(isolateMain), mainAccess]);
- }
-
- emitMain(CodeOutput output) {
+ emitMain(CodeOutput output, jsAst.Statement invokeMain) {
if (compiler.isMockCompilation) return;
- Element main = compiler.mainFunction;
- jsAst.Expression mainCallClosure = null;
- if (compiler.hasIsolateSupport) {
- Element isolateMain =
- backend.isolateHelperLibrary.find(JavaScriptBackend.START_ROOT_ISOLATE);
- mainCallClosure = buildIsolateSetupClosure(main, isolateMain);
- } else if (compiler.hasIncrementalSupport) {
- mainCallClosure = js(
- 'function() { return #(); }',
- backend.emitter.staticFunctionAccess(main));
- } else {
- mainCallClosure = backend.emitter.staticFunctionAccess(main);
- }
if (NativeGenerator.needsIsolateAffinityTagInitialization(backend)) {
jsAst.Statement nativeBoilerPlate =
@@ -951,47 +927,7 @@ class OldEmitter implements Emitter {
nativeBoilerPlate, compiler, monitor: compiler.dumpInfoTask));
}
- jsAst.Expression currentScriptAccess =
- generateEmbeddedGlobalAccess(embeddedNames.CURRENT_SCRIPT);
-
addComment('BEGIN invoke [main].', output);
- // This code finds the currently executing script by listening to the
- // onload event of all script tags and getting the first script which
- // finishes. Since onload is called immediately after execution this should
- // not substantially change execution order.
- jsAst.Statement invokeMain = js.statement('''
-(function (callback) {
- if (typeof document === "undefined") {
- callback(null);
- return;
- }
- if (document.currentScript) {
- callback(document.currentScript);
- return;
- }
-
- var scripts = document.scripts;
- function onLoad(event) {
- for (var i = 0; i < scripts.length; ++i) {
- scripts[i].removeEventListener("load", onLoad, false);
- }
- callback(event.target);
- }
- for (var i = 0; i < scripts.length; ++i) {
- scripts[i].addEventListener("load", onLoad, false);
- }
-})(function(currentScript) {
- #currentScript = currentScript;
-
- if (typeof dartMainRunner === "function") {
- dartMainRunner(#mainCallClosure, []);
- } else {
- #mainCallClosure([]);
- }
-})''', {'currentScript': currentScriptAccess,
- 'mainCallClosure': mainCallClosure});
-
- output.add(';');
output.addBuffer(jsAst.prettyPrint(invokeMain,
compiler, monitor: compiler.dumpInfoTask));
output.add(N);
@@ -1358,7 +1294,7 @@ class OldEmitter implements Emitter {
void emitMainOutputUnit(Program program,
Map<OutputUnit, String> deferredLoadHashes) {
- Fragment mainFragment = program.fragments.first;
+ MainFragment mainFragment = program.fragments.first;
OutputUnit mainOutputUnit = mainFragment.outputUnit;
LineColumnCollector lineColumnCollector;
@@ -1572,7 +1508,7 @@ class OldEmitter implements Emitter {
jsAst.FunctionDeclaration precompiledFunctionAst =
buildCspPrecompiledFunctionFor(mainOutputUnit);
emitInitFunction(mainOutput);
- emitMain(mainOutput);
+ emitMain(mainOutput, mainFragment.invokeMain);
mainOutput.add('})()\n');
if (compiler.useContentSecurityPolicy) {

Powered by Google App Engine
This is Rietveld 408576698