Mac: Enable two finger double-tap smart zoom

Mac: Enable two finger double-tap smart zoom

BUG=452592
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189742

[ccameron, 2015-02-07 01:38:32]

ccameron@chromium.org changed reviewers:
+ aelias@chromium.org

[ccameron, 2015-02-07 01:38:32]

Blink side of the change (small bit)

[aelias_OOO_until_Jul13, 2015-02-07 01:48:01]

lgtm

https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFact...
File Source/web/WebInputEventFactoryMac.mm (right):

https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFact...
Source/web/WebInputEventFactoryMac.mm:1156: result.type =
WebInputEvent::GestureDoubleTap;
I think this is worth a comment:

// Map the OS X "double-tap with two fingers" zoom gesture to regular
GestureDoubleTap, because the effect is similar to single-finger double-tap zoom
on mobile platforms.  Note that tapCount is intentionally 1 since the gesture
type already encodes the information.

[ccameron, 2015-02-07 08:19:26]

New patchsets have been uploaded after l-g-t-m from aelias@chromium.org

[ccameron, 2015-02-07 08:19:41]

Thanks!

https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFact...
File Source/web/WebInputEventFactoryMac.mm (right):

https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFact...
Source/web/WebInputEventFactoryMac.mm:1156: result.type =
WebInputEvent::GestureDoubleTap;
On 2015/02/07 01:48:00, aelias wrote:
> I think this is worth a comment:
> 
> // Map the OS X "double-tap with two fingers" zoom gesture to regular
> GestureDoubleTap, because the effect is similar to single-finger double-tap
zoom
> on mobile platforms.  Note that tapCount is intentionally 1 since the gesture
> type already encodes the information.

Good idea (and thanks for the wording suggestion).

[ccameron, 2015-02-07 08:19:45]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2015-02-07 08:20:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/906623003/20001

[commit-bot: I haz the power, 2015-02-07 08:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-07 08:29:55]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41875)

[ccameron, 2015-02-07 09:02:28]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2015-02-07 09:02:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/906623003/20001

[commit-bot: I haz the power, 2015-02-07 11:26:42]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189742