Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 906623003: Mac: Enable two finger double-tap smart zoom (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mac: Enable two finger double-tap smart zoom BUG=452592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189742

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/web/WebInputEventFactoryMac.mm View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ccameron
Blink side of the change (small bit)
5 years, 10 months ago (2015-02-07 01:38:32 UTC) #2
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFactoryMac.mm File Source/web/WebInputEventFactoryMac.mm (right): https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFactoryMac.mm#newcode1156 Source/web/WebInputEventFactoryMac.mm:1156: result.type = WebInputEvent::GestureDoubleTap; I think this is worth ...
5 years, 10 months ago (2015-02-07 01:48:01 UTC) #3
ccameron
Thanks! https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFactoryMac.mm File Source/web/WebInputEventFactoryMac.mm (right): https://codereview.chromium.org/906623003/diff/1/Source/web/WebInputEventFactoryMac.mm#newcode1156 Source/web/WebInputEventFactoryMac.mm:1156: result.type = WebInputEvent::GestureDoubleTap; On 2015/02/07 01:48:00, aelias wrote: ...
5 years, 10 months ago (2015-02-07 08:19:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906623003/20001
5 years, 10 months ago (2015-02-07 08:20:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41875)
5 years, 10 months ago (2015-02-07 08:29:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906623003/20001
5 years, 10 months ago (2015-02-07 09:02:43 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 11:26:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189742

Powered by Google App Engine
This is Rietveld 408576698