extensions/renderer/user_script_set.cc - Issue 906493004: Refactoring: de-couple Extensions from "script injection System" [render side]:2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/user_script_set.cc

Issue 906493004: Refactoring: de-couple Extensions from "script injection System" [render side]:2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_1

Patch Set: Rebase. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/user_script_set.cc

diff --git a/extensions/renderer/user_script_set.cc b/extensions/renderer/user_script_set.cc

index 65d7d7db36a2ba9bf9ddd60dbd8719486d361152..1b55ebc1b94c2be4ef252a60d3e530cfc71613cd 100644

--- a/extensions/renderer/user_script_set.cc

+++ b/extensions/renderer/user_script_set.cc

@@ -217,8 +217,7 @@ scoped_ptr<ScriptInjection> UserScriptSet::GetInjectionForScript(

injector.Pass(),

web_frame->toWebLocalFrame(),

host_id,

- // TODO(hanxi): store and obtain the instance id from the UserScript.

- HostID::kDefaultInstanceId,

+ script->consumer_instance_info(),

run_location,

tab_id));

}

« extensions/renderer/script_injection.cc ('K') | « extensions/renderer/user_script_injector.cc ('k') | no next file » | no next file with comments »