Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 906493004: Refactoring: de-couple Extensions from "script injection System" [render side]:2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_1
Patch Set: Rebase. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/script_injection_manager.cc
diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc
index b2558b15a99313cb0b74228de9e4faf1986019a4..928f964089cc65077326b6185bec2a2ede0f44e4 100644
--- a/extensions/renderer/script_injection_manager.cc
+++ b/extensions/renderer/script_injection_manager.cc
@@ -436,9 +436,11 @@ void ScriptInjectionManager::HandleExecuteCode(
scoped_ptr<ScriptInjection> injection(new ScriptInjection(
scoped_ptr<ScriptInjector>(
new ProgrammaticScriptInjector(params, main_frame)),
- main_frame,
- HostID(HostID::EXTENSIONS, params.extension_id),
- params.is_web_view ? params.instance_id : HostID::kDefaultInstanceId,
+ main_frame, HostID(HostID::EXTENSIONS, params.extension_id),
+ ConsumerInstanceInfo(
+ params.is_web_view ? ConsumerInstanceInfo::WEBVIEW
+ : ConsumerInstanceInfo::TAB,
+ params.is_web_view ? params.instance_id : HostID::kDefaultInstanceId),
static_cast<UserScript::RunLocation>(params.run_at),
ExtensionHelper::Get(render_view)->tab_id()));

Powered by Google App Engine
This is Rietveld 408576698