extensions/renderer/script_injection_manager.cc - Issue 906493004: Refactoring: de-couple Extensions from "script injection System" [render side]:2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injection_manager.cc

Issue 906493004: Refactoring: de-couple Extensions from "script injection System" [render side]:2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@decouple_brower_isolated_world_1

Patch Set: Rebase and remove ConsumerInstanceInfo(id). Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/script_injection.cc ('K') | « extensions/renderer/script_injection.cc ('k') | extensions/renderer/user_script_injector.cc » ('j') | extensions/renderer/user_script_injector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_injection_manager.cc

diff --git a/extensions/renderer/script_injection_manager.cc b/extensions/renderer/script_injection_manager.cc

index 93862dd04bdfe1109bf23c223ccef4cb734ec90e..2e1a747cb172673c8fc6d1e4a9bf97d58bdffe00 100644

--- a/extensions/renderer/script_injection_manager.cc

+++ b/extensions/renderer/script_injection_manager.cc

@@ -438,6 +438,8 @@ void ScriptInjectionManager::HandleExecuteCode(

new ProgrammaticScriptInjector(params, main_frame)),

main_frame,

HostID(HostID::EXTENSIONS, params.extension_id),

+ params.is_web_view ? UserScript::ConsumerInstanceType::WEBVIEW

+ : UserScript::ConsumerInstanceType::TAB,

static_cast<UserScript::RunLocation>(params.run_at),

ExtensionHelper::Get(render_view)->tab_id()));