Refactoring: de-couple Extensions from "script injection System" [render side]:2

chrome/browser/extensions/user_script_loader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/user_script_loader.h"
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 423 matching lines @@
     // though it removes the possibility that freeing the shared memory block
     // would open up enough FDs for long enough for a retry to succeed.
 
     // Pretend the extension change didn't happen.
     return;
   }
 
   // We've got scripts ready to go.
   shared_memory_.reset(shared_memory.release());
 
+  // If user scripts are comming from a <webview>, will only notify the
+  // RenderProcessHost of that <webview>; otherwise will notify all of the
+  // RenderProcessHosts.
+  bool is_web_view = false;
+  int render_process_id = -1;
+  const UserScriptList* scripts = user_scripts.get();
+  if (scripts && !scripts->empty() &&
+      (*scripts)[0].consumer_instance_info().type() ==
+          ConsumerInstanceInfo::WEBVIEW) {
+    DCHECK(scripts->size() == 1);
+    is_web_view = true;
+    render_process_id = (*scripts)[0].routing_info().render_process_id;
+  }
+
   for (content::RenderProcessHost::iterator i(
            content::RenderProcessHost::AllHostsIterator());
        !i.IsAtEnd();
        i.Advance()) {
+    if (is_web_view) {
+      if (i.GetCurrentValue()->GetID() != render_process_id) {

[Fady Samuel, 2015/02/11 19:08:22]

if (is_web_view && i.GetCurrentValue()->GetID() != render_process_id)
  continue;

...

+        continue;
+      } else {

[Fady Samuel, 2015/02/11 19:08:22]

Not necessary.

[Xi Han, 2015/02/11 21:57:24]

I add the else for early break (line 467 "break"). This is because each webview
will only have one renderProcessHost, once we find that one, we will send
message and break from the loop.

[Xi Han, 2015/02/11 22:06:57]

Adopt Fady's suggestion.

+        SendUpdate(i.GetCurrentValue(), shared_memory_.get(), changed_hosts_);
+        break;
+      }
+    }
     SendUpdate(i.GetCurrentValue(), shared_memory_.get(), changed_hosts_);
   }
   changed_hosts_.clear();
 
   content::NotificationService::current()->Notify(
       extensions::NOTIFICATION_USER_SCRIPTS_UPDATED,
       content::Source<Profile>(profile_),
       content::Details<base::SharedMemory>(shared_memory_.get()));
 }
 
@@ skipping 25 matching lines @@
   for (const HostID& id : changed_hosts)
     changed_ids_set.insert(id.id());
 
   if (base::SharedMemory::IsHandleValid(handle_for_process)) {
     process->Send(new ExtensionMsg_UpdateUserScripts(
         handle_for_process, host_id().id(), changed_ids_set));
   }
 }
 
 }  // namespace extensions