Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 906463002: add support for all can read interceptors (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add support for all can read interceptors R=verwaest@chromium.org BUG= Committed: https://crrev.com/313b24dbc24b64babf53c1830c2b23170ee1c269 Cr-Commit-Position: refs/heads/master@{#26522}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : non-recursive version #

Patch Set 5 : named recursion #

Patch Set 6 : indexed recursion #

Patch Set 7 : fixes #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -46 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 5 chunks +13 lines, -4 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 5 chunks +17 lines, -18 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 5 4 chunks +12 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 chunks +102 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 2 3 4 5 6 7 8 9 1 chunk +201 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcarney
ptal, i'll add some more tests on monday for nested iterators
5 years, 10 months ago (2015-02-06 18:44:08 UTC) #3
Toon Verwaest
LGTM. As discussed: in case of interceptor-exception in case of *WithFailedAccessCheck, just report failed access ...
5 years, 10 months ago (2015-02-09 10:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906463002/200001
5 years, 10 months ago (2015-02-09 11:11:38 UTC) #7
commit-bot: I haz the power
Committed patchset #10 (id:200001)
5 years, 10 months ago (2015-02-09 11:33:42 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 11:34:02 UTC) #9
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/313b24dbc24b64babf53c1830c2b23170ee1c269
Cr-Commit-Position: refs/heads/master@{#26522}

Powered by Google App Engine
This is Rietveld 408576698