Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 906413003: Update {virtual,override} to follow C++11 style in content/common/gpu/media (Closed)

Created:
5 years, 10 months ago by mrunal
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in content/common/gpu/media This change followed by the virtual methods and override/final section of http://www.chromium.org/developers/coding-style/chromium-style-checker-errors. Only one of {virtual,override,final} should be used for each declaration, since override implies virtual. BUG=417463 Committed: https://crrev.com/db2cb708e91f0a68ace75f4141636019ff833e16 Cr-Commit-Position: refs/heads/master@{#316894}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.h View 1 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mrunal
Can you please take a look?
5 years, 10 months ago (2015-02-10 23:11:57 UTC) #2
Pawel Osciak
Please follow indentation rules in Coding Style http://www.chromium.org/developers/coding-style. https://codereview.chromium.org/906413003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.h File content/common/gpu/media/dxva_video_decode_accelerator.h (right): https://codereview.chromium.org/906413003/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.h#newcode57 content/common/gpu/media/dxva_video_decode_accelerator.h:57: Client* ...
5 years, 10 months ago (2015-02-12 04:55:12 UTC) #3
mrunal
Fixed it.
5 years, 10 months ago (2015-02-12 17:45:41 UTC) #4
mrunal
Can you PTAL?
5 years, 10 months ago (2015-02-18 03:03:08 UTC) #5
Pawel Osciak
lgtm
5 years, 10 months ago (2015-02-18 04:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906413003/20001
5 years, 10 months ago (2015-02-18 19:15:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 21:23:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 21:24:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db2cb708e91f0a68ace75f4141636019ff833e16
Cr-Commit-Position: refs/heads/master@{#316894}

Powered by Google App Engine
This is Rietveld 408576698