Issue 906403008: Revert of Temporarily disabling AppRTC test on windows.

Issue 906403008: Revert of Temporarily disabling AppRTC test on windows. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium

Modified:
5 years, 10 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Temporarily disabling AppRTC test on windows. (patchset #1 id:1 of https://codereview.chromium.org/908483003/) Reason for revert: This test should now be fixed. Original issue's description: > Temporarily disabling AppRTC test on windows. > > https://github.com/webrtc/apprtc/issues/48 > > BUG=455758 > R=kjellander@chromium.org > > Committed: https://crrev.com/1511092cac89c527343c0c9ab4e0eb3ac1ba3762 > Cr-Commit-Position: refs/heads/master@{#315028} TBR=kjellander@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455758 Committed: https://crrev.com/e5da1ccacaa24efd6af1382b1d0e5fc8b3b85685 Cr-Commit-Position: refs/heads/master@{#315540}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 6 (0 generated)

phoglund_chromium

Created Revert of Temporarily disabling AppRTC test on windows.

5 years, 10 months ago (2015-02-10 11:36:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906403008/1

5 years, 10 months ago (2015-02-10 11:36:52 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/e5da1ccacaa24efd6af1382b1d0e5fc8b3b85685 Cr-Commit-Position: refs/heads/master@{#315540}

5 years, 10 months ago (2015-02-10 11:37:57 UTC) #4

kjellander_chromium

5 years, 10 months ago (2015-02-10 12:06:34 UTC) #6

Message was sent while issue was closed.

On 2015/02/10 12:06:08, kjellander wrote:
> lgtm, you gotta love drover.

(or the Revert button)