Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Issue 906343002: Added enum checks since enums are now supported in the IDL (Closed)

Created:
5 years, 10 months ago by terry
Modified:
5 years, 10 months ago
Reviewers:
vsm, Alan Knight, rmacnak, siva
CC:
reviews+dom_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M Source/bindings/dart/scripts/dart_dictionary.py View 2 chunks +5 lines, -1 line 0 comments Download
M Source/bindings/dart/scripts/dart_methods.py View 2 chunks +5 lines, -1 line 0 comments Download
M Source/bindings/dart/scripts/dart_types.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/dart/scripts/dart_utilities.py View 2 chunks +9 lines, -1 line 0 comments Download
M Source/bindings/dart/scripts/templates/methods_cpp.template View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
terry
Enums are now checked however, I want to fix this in Dart code instead of ...
5 years, 10 months ago (2015-02-09 16:52:49 UTC) #2
terry
5 years, 10 months ago (2015-02-09 17:34:10 UTC) #4
siva
lgtm
5 years, 10 months ago (2015-02-09 19:11:31 UTC) #5
vsm
lgtm
5 years, 10 months ago (2015-02-09 21:04:02 UTC) #6
terry
5 years, 10 months ago (2015-02-09 21:09:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 189841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698