Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 906323003: [CSS Grid Layout] Columns set in percentages collapse to auto width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sergio-indefinite
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 LayoutUnit computeContentLogicalHeight(const Length& height, LayoutUnit intr insicContentHeight) const; 448 LayoutUnit computeContentLogicalHeight(const Length& height, LayoutUnit intr insicContentHeight) const;
449 LayoutUnit computeContentAndScrollbarLogicalHeightUsing(const Length& height , LayoutUnit intrinsicContentHeight) const; 449 LayoutUnit computeContentAndScrollbarLogicalHeightUsing(const Length& height , LayoutUnit intrinsicContentHeight) const;
450 LayoutUnit computeReplacedLogicalWidthUsing(const Length& width) const; 450 LayoutUnit computeReplacedLogicalWidthUsing(const Length& width) const;
451 LayoutUnit computeReplacedLogicalWidthRespectingMinMaxWidth(LayoutUnit logic alWidth, ShouldComputePreferred = ComputeActual) const; 451 LayoutUnit computeReplacedLogicalWidthRespectingMinMaxWidth(LayoutUnit logic alWidth, ShouldComputePreferred = ComputeActual) const;
452 LayoutUnit computeReplacedLogicalHeightUsing(const Length& height) const; 452 LayoutUnit computeReplacedLogicalHeightUsing(const Length& height) const;
453 LayoutUnit computeReplacedLogicalHeightRespectingMinMaxHeight(LayoutUnit log icalHeight) const; 453 LayoutUnit computeReplacedLogicalHeightRespectingMinMaxHeight(LayoutUnit log icalHeight) const;
454 454
455 virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = Com puteActual) const; 455 virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = Com puteActual) const;
456 virtual LayoutUnit computeReplacedLogicalHeight() const; 456 virtual LayoutUnit computeReplacedLogicalHeight() const;
457 457
458 static bool logicalWidthIsResolvableFromBlock(const RenderBlock* containingB lock);
459 bool hasDefiniteLogicalWidth() const;
458 static bool percentageLogicalHeightIsResolvableFromBlock(const RenderBlock* containingBlock, bool outOfFlowPositioned); 460 static bool percentageLogicalHeightIsResolvableFromBlock(const RenderBlock* containingBlock, bool outOfFlowPositioned);
461 bool hasDefiniteLogicalHeight() const;
459 LayoutUnit computePercentageLogicalHeight(const Length& height) const; 462 LayoutUnit computePercentageLogicalHeight(const Length& height) const;
460 463
461 // Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.) 464 // Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)
462 virtual LayoutUnit availableLogicalWidth() const { return contentLogicalWidt h(); } 465 virtual LayoutUnit availableLogicalWidth() const { return contentLogicalWidt h(); }
463 virtual LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const; 466 virtual LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const;
464 LayoutUnit availableLogicalHeightUsing(const Length&, AvailableLogicalHeight Type) const; 467 LayoutUnit availableLogicalHeightUsing(const Length&, AvailableLogicalHeight Type) const;
465 468
466 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height. 469 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height.
467 // Relative positioning is one of those cases, since left/top offsets are ph ysical. 470 // Relative positioning is one of those cases, since left/top offsets are ph ysical.
468 LayoutUnit availableWidth() const { return style()->isHorizontalWritingMode( ) ? availableLogicalWidth() : availableLogicalHeight(IncludeMarginBorderPadding) ; } 471 LayoutUnit availableWidth() const { return style()->isHorizontalWritingMode( ) ? availableLogicalWidth() : availableLogicalHeight(IncludeMarginBorderPadding) ; }
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 if (UNLIKELY(inlineBoxWrapper() != 0)) 845 if (UNLIKELY(inlineBoxWrapper() != 0))
843 deleteLineBoxWrapper(); 846 deleteLineBoxWrapper();
844 } 847 }
845 848
846 ensureRareData().m_inlineBoxWrapper = boxWrapper; 849 ensureRareData().m_inlineBoxWrapper = boxWrapper;
847 } 850 }
848 851
849 } // namespace blink 852 } // namespace blink
850 853
851 #endif // RenderBox_h 854 #endif // RenderBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698