Issue 906313002: Re-enabling building on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 906313002: Re-enabling building on Windows. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium

Modified:
5 years, 10 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/webrtc/webrtc.DEPS/

Visibility:
Public.

Re-enabling building on Windows. This has been fixed now in the GitHub repo. TEST=grunt build on win workstation and full test run. BUG=455758 R=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/293991

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	build_apprtc_appengine_app.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

kjellander_chromium

nice! make sure to monitor the next build though (unexpected things tend to pop up ...

5 years, 10 months ago (2015-02-09 14:53:25 UTC) #3

phoglund_chromium

On 2015/02/09 14:53:25, kjellander wrote: > nice! make sure to monitor the next build though ...

5 years, 10 months ago (2015-02-09 14:58:45 UTC) #4

phoglund_chromium

5 years, 10 months ago (2015-02-09 14:59:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r293991 (presubmit successful).