Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 906283003: PlzNavigate: Support data urls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + change to unit test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl_unittest.cc
diff --git a/content/browser/frame_host/navigator_impl_unittest.cc b/content/browser/frame_host/navigator_impl_unittest.cc
index 82a49874ec9561ca5d6d17ec8a0aeb1c70cb8cce..7eb3be69a9b3a147f42a6fa268b80ab8c031d886 100644
--- a/content/browser/frame_host/navigator_impl_unittest.cc
+++ b/content/browser/frame_host/navigator_impl_unittest.cc
@@ -941,4 +941,50 @@ TEST_F(NavigatorTestWithBrowserSideNavigation,
EXPECT_FALSE(rfhm->IsOnSwappedOutList(rfh1));
}
+// PlzNavigate: Verify that data urls are properly handled.
+TEST_F(NavigatorTestWithBrowserSideNavigation, DataUrls) {
+ const GURL kUrl1("http://wikipedia.org/");
+ const GURL kUrl2("data:text/html,test");
+
+ // Navigate to an initial site.
+ contents()->NavigateAndCommit(kUrl1);
+ FrameTreeNode* node = main_test_rfh()->frame_tree_node();
+
+ // Navigate to a data url.
+ RequestNavigation(node, kUrl2);
+ NavigationRequest* navigation_request =
+ GetNavigationRequestForFrameTreeNode(node);
+ ASSERT_TRUE(navigation_request);
+ EXPECT_EQ(NavigationRequest::WAITING_FOR_RENDERER_RESPONSE,
+ navigation_request->state());
+ main_test_rfh()->SendBeforeUnloadACK(true);
+
+ // The request should not have been sent to the IO thread but committed
+ // immediately.
+ EXPECT_EQ(NavigationRequest::RESPONSE_STARTED,
+ navigation_request->state());
+ EXPECT_FALSE(navigation_request->loader_for_testing());
+ TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
+ ASSERT_TRUE(speculative_rfh);
+ speculative_rfh->SendNavigate(0, kUrl2);
+ EXPECT_EQ(main_test_rfh(), speculative_rfh);
+
+ // Go back to the initial site.
+ contents()->NavigateAndCommit(kUrl1);
+
+ // Do a renderer-initiated navigation to a data url. The request should not be
+ // sent to the IO thread, nor committed.
+ TestRenderFrameHost* main_rfh = main_test_rfh();
+ main_rfh->SendBeginNavigationWithURL(kUrl2, true);
+ navigation_request = GetNavigationRequestForFrameTreeNode(node);
+ ASSERT_TRUE(navigation_request);
+ EXPECT_EQ(NavigationRequest::RESPONSE_STARTED,
+ navigation_request->state());
+ EXPECT_FALSE(navigation_request->loader_for_testing());
+ speculative_rfh = GetSpeculativeRenderFrameHost(node);
+ ASSERT_TRUE(speculative_rfh);
+ speculative_rfh->SendNavigate(0, kUrl2);
+ EXPECT_EQ(main_test_rfh(), speculative_rfh);
+}
+
} // namespace content
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698