PlzNavigate: Support data urls

content/browser/frame_host/navigator_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/frame_host/navigation_request.h"
@@ skipping 923 matching lines @@
             GetSpeculativeRenderFrameHost(node)->rfh_state());
   EXPECT_TRUE(DidRenderFrameHostRequestCommit(rfh1));
   EXPECT_FALSE(DidRenderFrameHostRequestCommit(main_test_rfh()));
 
   rfh1->SendNavigate(1, kUrl1);
   EXPECT_EQ(rfh1, main_test_rfh());
   EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh1->rfh_state());
   EXPECT_FALSE(rfhm->IsOnSwappedOutList(rfh1));
 }
 
+// PlzNavigate: Verify that data urls are properly handled.

[Charlie Reis, 2015/02/20 22:11:50]

Can you add a second test for base_url_for_data_url?

[clamy, 2015/02/26 15:28:36]

What exactly would you want to test in that test? That we properly have the
base_url_for_data_url and support receiving the DidCommitProvisionalLoad IPC for
the base_url_for_data_url? Speaking of which, should the url used to select a
renderer to display the request be the data url itself or the
base_url_for_data_url?

+TEST_F(NavigatorTestWithBrowserSideNavigation, DataUrls) {
+  const GURL kUrl1("http://wikipedia.org/");
+  const GURL kUrl2("data:test");
+
+  // Navigate to an initial site.
+  contents()->NavigateAndCommit(kUrl1);
+  FrameTreeNode* node = main_test_rfh()->frame_tree_node();
+
+  // Navigate to a data url.
+  RequestNavigation(node, kUrl2);
+  NavigationRequest* navigation_request =
+      GetNavigationRequestForFrameTreeNode(node);
+  ASSERT_TRUE(navigation_request);
+  EXPECT_EQ(NavigationRequest::WAITING_FOR_RENDERER_RESPONSE,
+            navigation_request->state());
+  main_test_rfh()->SendBeforeUnloadACK(true);
+
+  // The request should not have been sent to the IO thread but committed
+  // immediately.
+  EXPECT_EQ(NavigationRequest::RESPONSE_STARTED,
+            navigation_request->state());
+  EXPECT_FALSE(navigation_request->loader_for_testing());
+  TestRenderFrameHost* speculative_rfh = GetSpeculativeRenderFrameHost(node);
+  ASSERT_TRUE(speculative_rfh);

[Charlie Reis, 2015/02/20 22:11:50]

Why is there a speculative RFH?  NavigatorImpl::BeginNavigation doesn't call
RFHM::BeginNavigation for data URLs.

[carlosk, 2015/02/23 10:50:28]

Line 960 causes it to be called.

[clamy, 2015/02/26 15:28:36]

No, in that case NavigationRequest::BeginNavigation will call
NavigatorImpl::CommitNavigation, which in turn calls
RFHM::GetFrameHostForNavigation which creates it.

+  speculative_rfh->SendNavigate(0, kUrl2);
+  EXPECT_EQ(main_test_rfh(), speculative_rfh);
+
+  // Go back to the initial site.
+  contents()->NavigateAndCommit(kUrl1);
+
+  // Do a renderer-initiated navigation to a data url. The request should be

[Charlie Reis, 2015/02/20 22:11:50]

should not?

[clamy, 2015/02/26 15:28:36]

Done.

+  // sent to the IO thread, nor committed.
+  TestRenderFrameHost* main_rfh = main_test_rfh();
+  main_rfh->SendBeginNavigationWithURL(kUrl2);
+  navigation_request = GetNavigationRequestForFrameTreeNode(node);
+  ASSERT_TRUE(navigation_request);
+  EXPECT_EQ(NavigationRequest::RESPONSE_STARTED,
+            navigation_request->state());
+  EXPECT_FALSE(navigation_request->loader_for_testing());
+  EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
+  main_rfh->SendNavigate(1, kUrl2);
+  EXPECT_EQ(main_test_rfh(), main_rfh);
+}
+
 }  // namespace content