PlzNavigate: Support data urls

content/browser/frame_host/navigation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_request.h"
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigation_request_info.h"
 #include "content/browser/frame_host/navigator.h"
@@ skipping 67 matching lines @@
 
   FrameMsg_UILoadMetricsReportType::Value report_type =
       FrameMsg_UILoadMetricsReportType::NO_REPORT;
   base::TimeTicks ui_timestamp = base::TimeTicks();
 #if defined(OS_ANDROID)
   if (!entry.intent_received_timestamp().is_null())
     report_type = FrameMsg_UILoadMetricsReportType::REPORT_INTENT;
   ui_timestamp = entry.intent_received_timestamp();
 #endif
 
+  const GURL history_url_for_data_url =
+    entry.GetBaseURLForDataURL().is_empty()? GURL() : entry.GetVirtualURL();

[Charlie Reis, 2015/02/18 00:43:25]

nit: Space before ?

[clamy, 2015/02/20 17:05:58]

Done.

+
   scoped_ptr<NavigationRequest> navigation_request(new NavigationRequest(
       frame_tree_node,
       CommonNavigationParams(entry.GetURL(), entry.GetReferrer(),
                              entry.GetTransitionType(), navigation_type,
                              !entry.IsViewSourceMode(),ui_timestamp,
-                             report_type),
+                             report_type, entry.GetBaseURLForDataURL(),
+                             history_url_for_data_url),
       BeginNavigationParams(method, headers.ToString(),
                             LoadFlagFromNavigationType(navigation_type),
                             false),
       CommitNavigationParams(entry.GetPageState(),
                              entry.GetIsOverridingUserAgent(),
                              navigation_start),
       request_body, true, &entry));
   return navigation_request.Pass();
 }
 
@@ skipping 47 matching lines @@
   bool parent_is_main_frame = !frame_tree_node->parent() ?
       false : frame_tree_node->parent()->IsMainFrame();
   info_.reset(new NavigationRequestInfo(
         common_params, begin_params, first_party_for_cookies,
         frame_tree_node->IsMainFrame(), parent_is_main_frame, body));
 }
 
 NavigationRequest::~NavigationRequest() {
 }
 
-void NavigationRequest::BeginNavigation() {
+bool NavigationRequest::BeginNavigation() {
   DCHECK(!loader_);
   DCHECK(state_ == NOT_STARTED || state_ == WAITING_FOR_RENDERER_RESPONSE);
   state_ = STARTED;
-  loader_ = NavigationURLLoader::Create(
-      frame_tree_node_->navigator()->GetController()->GetBrowserContext(),
-      frame_tree_node_->frame_tree_node_id(), info_.Pass(), this);
+
+  if (ShouldMakeNetworkRequestForNavigation(common_params_.url)) {
+    loader_ = NavigationURLLoader::Create(
+        frame_tree_node_->navigator()->GetController()->GetBrowserContext(),
+        frame_tree_node_->frame_tree_node_id(), info_.Pass(), this);
+    return true;
+  }
+
+  state_ = RESPONSE_STARTED;
+  // There is no need to make a network request for this navigation, so commit
+  // it immediately if it was browser initiated. If it was renderer initiated,
+  // the renderer should already be trying to commit it.

[Charlie Reis, 2015/02/18 00:43:25]

I'm not sure I agree with the second sentence.  Data URLs don't commit
synchronously, and it's not clear to me whether the renderer process should
directly commit them.  Why would they not go through the browser process?

[clamy, 2015/02/20 17:05:58]

Changed the behavior so that now we always go through the commit step. I guess
the only renderer-initiated navigations that the renderer should pursue by
itself are the same-document ones.

+  if (browser_initiated_) {
+    frame_tree_node_->navigator()->CommitNavigation(

[carlosk, 2015/02/17 12:35:09]

I find it weird that we're calling into Navigator from a class named
NavitationRequest (it sounds like a static thing) but as we're already doing so
in 2 different instances this doesn't change anything. It's maybe something we'd
want to figure out later...

[clamy, 2015/02/17 12:54:28]

I am not quite sure what you mean there. There are several instances of
Navigator, so we need the right one to commit the navigation.

[carlosk, 2015/02/17 14:11:23]

Yes, one navigator per node. I's just an architectural concern that maybe a new
delegate would solve.

[Charlie Reis, 2015/02/18 00:43:25]

To be clear, there is not one Navigator per FrameTreeNode.  In most cases, all
FrameTreeNodes of a WebContents share the same Navigator.  We made it possible
for a FTN to have a different Navigator to support things like the <webview> tag
in apps.

[carlosk, 2015/02/18 15:45:08]

Acknowledged.

+        frame_tree_node_, nullptr, scoped_ptr<StreamHandle>());
+  }
+  return false;
 
   // TODO(davidben): Fire (and add as necessary) observer methods such as
   // DidStartProvisionalLoadForFrame for the navigation.
 }
 
 void NavigationRequest::OnRequestRedirected(
     const net::RedirectInfo& redirect_info,
     const scoped_refptr<ResourceResponse>& response) {
   // TODO(davidben): Track other changes from redirects. These are important
   // for, e.g., reloads.
@@ skipping 19 matching lines @@
   // TODO(davidben): Network failures should display a network error page.
   NOTIMPLEMENTED() << " where net_error=" << net_error;
 }
 
 void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {
   frame_tree_node_->navigator()->LogResourceRequestTime(timestamp,
                                                         common_params_.url);
 }
 
 }  // namespace content