Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: pkg/compiler/lib/src/compiler.dart

Issue 906273002: Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 2204 matching lines...) Expand 10 before | Expand all | Expand 10 after
2215 message = message(); 2215 message = message();
2216 } 2216 }
2217 throw new SpannableAssertionFailure(spannable, message); 2217 throw new SpannableAssertionFailure(spannable, message);
2218 } 2218 }
2219 return true; 2219 return true;
2220 } 2220 }
2221 2221
2222 /// Returns `true` when [s] is private if used as an identifier. 2222 /// Returns `true` when [s] is private if used as an identifier.
2223 bool isPrivateName(String s) => !s.isEmpty && s.codeUnitAt(0) == $_; 2223 bool isPrivateName(String s) => !s.isEmpty && s.codeUnitAt(0) == $_;
2224 2224
2225 /// Returns `true` when [s] is public if used as an identifier.
2226 bool isPublicName(String s) => !isPrivateName(s);
2227
2228 /// A sink that drains into /dev/null. 2225 /// A sink that drains into /dev/null.
2229 class NullSink implements EventSink<String> { 2226 class NullSink implements EventSink<String> {
2230 final String name; 2227 final String name;
2231 2228
2232 NullSink(this.name); 2229 NullSink(this.name);
2233 2230
2234 add(String value) {} 2231 add(String value) {}
2235 2232
2236 void addError(Object error, [StackTrace stackTrace]) {} 2233 void addError(Object error, [StackTrace stackTrace]) {}
2237 2234
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
2410 return futureClass.computeType(compiler).createInstantiation([elementType]); 2407 return futureClass.computeType(compiler).createInstantiation([elementType]);
2411 } 2408 }
2412 2409
2413 @override 2410 @override
2414 InterfaceType streamType([DartType elementType = const DynamicType()]) { 2411 InterfaceType streamType([DartType elementType = const DynamicType()]) {
2415 return streamClass.computeType(compiler).createInstantiation([elementType]); 2412 return streamClass.computeType(compiler).createInstantiation([elementType]);
2416 } 2413 }
2417 } 2414 }
2418 2415
2419 typedef void InternalErrorFunction(Spannable location, String message); 2416 typedef void InternalErrorFunction(Spannable location, String message);
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698