Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 906243002: Make it easier to test OSR with %OptimizeOsr() runtime call. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make it easier to test OSR with %OptimizeOsr() runtime call. This call triggers OSR for the current function. And also allows explicitly testing OSR on the top-level code. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/4c302ca2906874e8efe4f1185fa1fa688ea714d6 Cr-Commit-Position: refs/heads/master@{#26523}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -122 lines) Patch
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 2 chunks +41 lines, -7 lines 0 comments Download
M test/mjsunit/compiler/optimized-for-in.js View 3 chunks +3 lines, -9 lines 0 comments Download
M test/mjsunit/compiler/osr-manual1.js View 1 chunk +16 lines, -28 lines 0 comments Download
M test/mjsunit/compiler/osr-manual2.js View 1 chunk +15 lines, -27 lines 0 comments Download
M test/mjsunit/compiler/osr-regex-id.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/compiler/osr-simple.js View 1 chunk +2 lines, -25 lines 0 comments Download
A test/mjsunit/compiler/osr-top1.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/osr-top2.js View 1 1 chunk +6 lines, -13 lines 0 comments Download
A test/mjsunit/compiler/osr-top3.js View 1 1 chunk +22 lines, -0 lines 0 comments Download
M test/mjsunit/regress-sync-optimized-lists.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-379770.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-387599.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
titzer
5 years, 10 months ago (2015-02-09 10:52:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906243002/1
5 years, 10 months ago (2015-02-09 10:54:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-09 10:54:32 UTC) #5
Michael Starzinger
LGTM. https://codereview.chromium.org/906243002/diff/20001/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/906243002/diff/20001/src/runtime/runtime-test.cc#newcode85 src/runtime/runtime-test.cc:85: HandleScope scope(isolate); nit: Please place the HandleScope first ...
5 years, 10 months ago (2015-02-09 12:11:07 UTC) #6
titzer
https://codereview.chromium.org/906243002/diff/20001/src/runtime/runtime-test.cc File src/runtime/runtime-test.cc (right): https://codereview.chromium.org/906243002/diff/20001/src/runtime/runtime-test.cc#newcode85 src/runtime/runtime-test.cc:85: HandleScope scope(isolate); On 2015/02/09 12:11:06, Michael Starzinger wrote: > ...
5 years, 10 months ago (2015-02-09 12:16:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906243002/40001
5 years, 10 months ago (2015-02-09 12:16:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 12:47:38 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 12:47:52 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c302ca2906874e8efe4f1185fa1fa688ea714d6
Cr-Commit-Position: refs/heads/master@{#26523}

Powered by Google App Engine
This is Rietveld 408576698