Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 906233002: Use nullptr instead of 0 in WebAudio (Closed)

Created:
5 years, 10 months ago by qi1988.yang
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use nullptr instead of 0 in WebAudio WebAudio uses 0 instead of nullptr in quite a few places. Update the code to use nullptr. BUG=455922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190881

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M Source/modules/webaudio/AudioBuffer.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 2 13 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/ChannelMergerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ChannelSplitterNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/OscillatorNode.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/PeriodicWave.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/audio/AudioArray.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/AudioBus.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/audio/AudioChannel.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/audio/AudioDSPKernel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioDestination.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFPanner.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/SincResampler.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/audio/mac/FFTFrameMac.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (10 generated)
qi1988.yang
Please take a look,thanks!
5 years, 10 months ago (2015-02-09 10:34:16 UTC) #2
Raymond Toy
On 2015/02/09 10:34:16, qi1988.yang wrote: > Please take a look,thanks! Fix the typo in the ...
5 years, 10 months ago (2015-02-09 19:21:24 UTC) #3
qi1988.yang
Please take a look, thanks very much!
5 years, 10 months ago (2015-02-10 05:15:06 UTC) #4
Raymond Toy
On 2015/02/10 05:15:06, qi1988.yang wrote: > Please take a look, thanks very much! Looks good. ...
5 years, 10 months ago (2015-02-10 16:59:27 UTC) #5
qi1988.yang
On 2015/02/10 16:59:27, Raymond Toy wrote: > On 2015/02/10 05:15:06, qi1988.yang wrote: > > Please ...
5 years, 10 months ago (2015-02-11 07:09:19 UTC) #6
qi1988.yang
On 2015/02/10 16:59:27, Raymond Toy wrote: > On 2015/02/10 05:15:06, qi1988.yang wrote: > > Please ...
5 years, 10 months ago (2015-02-11 07:09:20 UTC) #7
Raymond Toy
On 2015/02/11 07:09:20, qi1988.yang wrote: > On 2015/02/10 16:59:27, Raymond Toy wrote: > > On ...
5 years, 10 months ago (2015-02-11 17:57:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906233002/20001
5 years, 10 months ago (2015-02-12 02:49:00 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-12 02:49:03 UTC) #12
qi1988.yang
On 2015/02/11 17:57:05, Raymond Toy wrote: > On 2015/02/11 07:09:20, qi1988.yang wrote: > > On ...
5 years, 10 months ago (2015-02-12 03:14:36 UTC) #14
qi1988.yang
On 2015/02/11 17:57:05, Raymond Toy wrote: > On 2015/02/11 07:09:20, qi1988.yang wrote: > > On ...
5 years, 10 months ago (2015-02-12 03:14:37 UTC) #15
qi1988.yang
On 2015/02/12 03:14:37, qi1988.yang wrote: > On 2015/02/11 17:57:05, Raymond Toy wrote: > > On ...
5 years, 10 months ago (2015-02-13 06:21:08 UTC) #16
Raymond Toy
On 2015/02/13 06:21:08, qi1988.yang wrote: > On 2015/02/12 03:14:37, qi1988.yang wrote: > > On 2015/02/11 ...
5 years, 10 months ago (2015-02-13 17:18:10 UTC) #17
Raymond Toy
lgtm
5 years, 10 months ago (2015-02-13 17:18:59 UTC) #18
qi1988.yang
Excuse me, kbr! PTAL! Thanks very much!
5 years, 10 months ago (2015-02-25 02:00:27 UTC) #19
Ken Russell (switch to Gerrit)
lgtm
5 years, 10 months ago (2015-02-25 19:25:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906233002/20001
5 years, 10 months ago (2015-02-26 02:03:56 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/36586)
5 years, 10 months ago (2015-02-26 02:37:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906233002/40001
5 years, 10 months ago (2015-02-26 02:47:01 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906233002/40001
5 years, 10 months ago (2015-02-26 08:11:07 UTC) #30
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 09:12:02 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190881

Powered by Google App Engine
This is Rietveld 408576698