Issue 906223002: Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 906223002: Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (Closed)

Created:
5 years, 10 months ago by battre

Modified:
5 years, 10 months ago

Reviewers:
mmenke

CC:
cbentzel+watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@432398-cookie-settings-incognito

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (patchset #1 id:1 of https://codereview.chromium.org/892413007/) Reason for revert: Remove DumpWithoutCrashing() from URLRequestHttpJob again. See crbug.com/432398 for stacktraces uncovered by this. Original issue's description: > DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback > > BUG=432398 > > Committed: https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64 > Cr-Commit-Position: refs/heads/master@{#315052} TBR=mmenke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=432398 Committed: https://crrev.com/d027680f60ec148b55e39097495aafa17cbd2cd4 Cr-Commit-Position: refs/heads/master@{#315277}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	net/url_request/url_request_http_job.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

battre

Created Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback

5 years, 10 months ago (2015-02-09 09:50:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906223002/1

5 years, 10 months ago (2015-02-09 09:51:09 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 09:52:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d027680f60ec148b55e39097495aafa17cbd2cd4
Cr-Commit-Position: refs/heads/master@{#315277}