Oilpan: Rename heap classes

Oilpan: Rename heap classes

This CL renames heap classes as follows to make the naming more consistent

[Before]
BaseHeapPage <-- HeapPage, LargeObject
ThreadHeap <-- ThreadHeapForHeapPage, ThreadHeapForLargeObject

[After]
BasePage <-- NormalPage, LargeObjectPage
BasePageHeap <-- NormalPageHeap, LargeObjectHeap

Also this CL renames enum values of TypedHeaps (to avoid conflict with "LargeObjectHeap").

BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189806

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190030

[haraken, 2015-02-09 08:52:55]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com

[haraken, 2015-02-09 08:52:55]

PTAL. I'm not sure if these names are the best though.

[sof, 2015-02-09 09:30:37]

On 2015/02/09 08:52:55, haraken wrote:
> PTAL. I'm not sure if these names are the best though.

Names sort of work for me; LargeObjectPage & LargeObjectHeap might be clearer
(esp. for the former), albeit longer.

[haraken, 2015-02-09 09:47:27]

On 2015/02/09 09:30:37, sof wrote:
> On 2015/02/09 08:52:55, haraken wrote:
> > PTAL. I'm not sure if these names are the best though.
> 
> Names sort of work for me; LargeObjectPage & LargeObjectHeap might be clearer
> (esp. for the former), albeit longer.

BasePage & BaseHeap
NormalPage & NormalHeap
LargeObjectPage & LargeObjectHeap

?

[sof, 2015-02-09 09:58:04]

On 2015/02/09 09:47:27, haraken wrote:
> On 2015/02/09 09:30:37, sof wrote:
> > On 2015/02/09 08:52:55, haraken wrote:
> > > PTAL. I'm not sure if these names are the best though.
> > 
> > Names sort of work for me; LargeObjectPage & LargeObjectHeap might be
clearer
> > (esp. for the former), albeit longer.
> 
> BasePage & BaseHeap
> NormalPage & NormalHeap
> LargeObjectPage & LargeObjectHeap
> 
> ?

yes, but my naming sensibilities are questionable at times :)

[haraken, 2015-02-09 11:33:20]

On 2015/02/09 09:58:04, sof wrote:
> On 2015/02/09 09:47:27, haraken wrote:
> > On 2015/02/09 09:30:37, sof wrote:
> > > On 2015/02/09 08:52:55, haraken wrote:
> > > > PTAL. I'm not sure if these names are the best though.
> > > 
> > > Names sort of work for me; LargeObjectPage & LargeObjectHeap might be
> clearer
> > > (esp. for the former), albeit longer.
> > 
> > BasePage & BaseHeap
> > NormalPage & NormalHeap
> > LargeObjectPage & LargeObjectHeap
> > 
> > ?
> 
> yes, but my naming sensibilities are questionable at times :)

Done.

[sof, 2015-02-09 12:48:59]

lgtm

[haraken, 2015-02-09 13:43:24]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-02-09 13:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/906213002/40001

[commit-bot: I haz the power, 2015-02-09 14:28:56]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189806

[caseq, 2015-02-09 18:34:40]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/911663002/ by caseq@chromium.org.

The reason for reverting is: This is on top of
https://codereview.chromium.org/907943002/ which needs to be reverted due to
lots of browser test failures..

[haraken, 2015-02-12 06:00:35]

New patchsets have been uploaded after l-g-t-m from sigbjornf@opera.com

[haraken, 2015-02-12 06:00:57]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-02-12 06:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/906213002/60001

[commit-bot: I haz the power, 2015-02-12 07:19:51]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190030