shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value

LayoutTests/resources/js-test.js

Index: LayoutTests/resources/js-test.js
diff --git a/LayoutTests/resources/js-test.js b/LayoutTests/resources/js-test.js
index e4d56e4256eeb46c2152ed6dff9559d1c84d6e05..c1eb583721036191879793ea378735f6b2e478a2 100644
--- a/LayoutTests/resources/js-test.js
+++ b/LayoutTests/resources/js-test.js
@@ -291,7 +291,7 @@ function shouldBecomeEqual(_a, _b, _completionHandler, _timeout)
     _timeout = 500;
 
   var _bv;
-  var _condition = function() {
+  function _condition() {
     var _exception;
     var _av;
     try {
@@ -313,7 +313,7 @@ function shouldBecomeEqual(_a, _b, _completionHandler, _timeout)
     testFailed(_a + " failed to change to " + _bv + " in " + (_timeout / 1000) + " seconds.");
     _completionHandler();
   };
-  _waitForCondition(_condition, _failureTime, _completionHandler, _failureHandler);
+  setTimeout(_waitForCondition, 5, _condition, _failureTime, _completionHandler, _failureHandler);

[please use gerrit instead, 2015/02/17 16:28:48]

I'm still quite queasy about this change. We are slowing down each one of our
tests by 5 seconds? That's bad.

[yosin_UTC9, 2016/09/01 01:49:07]

It is "5ms" instead of "5s".
https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers/setTimeout

Could you have |const| variable to describe unit of delay?
e.g. const kDelayMilliseconds = 5;

BTW, 5ms is too small, since frame rate is 60Hz. 16ms may be enough.

 }
 
 function shouldBecomeEqualToString(value, reference, completionHandler, timeout)
@@ -411,7 +411,7 @@ function shouldBecomeDifferent(_a, _b, _completionHandler, _timeout)
     _timeout = 500;
 
   var _bv;
-  var _condition = function() {
+  function _condition() {
     var _exception;
     var _av;
     try {
@@ -433,7 +433,7 @@ function shouldBecomeDifferent(_a, _b, _completionHandler, _timeout)
     testFailed(_a + " did not become different from " + _bv + " in " + (_timeout / 1000) + " seconds.");
     _completionHandler();
   };
-  _waitForCondition(_condition, _failureTime, _completionHandler, _failureHandler);
+  setTimeout(_waitForCondition, 5, _condition, _failureTime, _completionHandler, _failureHandler);
 }
 
 function shouldBeTrue(a, quiet) { shouldBe(a, "true", quiet); }