shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value

LayoutTests/resources/js-test.js

Index: LayoutTests/resources/js-test.js
diff --git a/LayoutTests/resources/js-test.js b/LayoutTests/resources/js-test.js
index e4d56e4256eeb46c2152ed6dff9559d1c84d6e05..c1eb583721036191879793ea378735f6b2e478a2 100644
--- a/LayoutTests/resources/js-test.js
+++ b/LayoutTests/resources/js-test.js
@@ -291,7 +291,7 @@ function shouldBecomeEqual(_a, _b, _completionHandler, _timeout)
     _timeout = 500;
 
   var _bv;
-  var _condition = function() {
+  function _condition() {
     var _exception;
     var _av;
     try {
@@ -313,7 +313,7 @@ function shouldBecomeEqual(_a, _b, _completionHandler, _timeout)
     testFailed(_a + " failed to change to " + _bv + " in " + (_timeout / 1000) + " seconds.");
     _completionHandler();
   };
-  _waitForCondition(_condition, _failureTime, _completionHandler, _failureHandler);
+  setTimeout(_waitForCondition, 5, _condition, _failureTime, _completionHandler, _failureHandler);

[please use gerrit instead, 2015/02/10 22:59:20]

This is not necessary, because _waitForCondition() already runs setTimeout
internally.

[grzegorz, 2015/02/11 10:54:23]

Not really, assuming existing implementation, before _waitForCondition() we
check condition above and remember it in '_condition' variable, and then inside
_waitForCondition() we check it. For example, 

shouldBecomeEqual(internals.hasSpellingMarker(document, "welllcome"), false);

is always passing as hasSpellingMarker() returns false as the spelling markers
were requested and they will be available later. Actually, there is no
difference between

shouldBecomeEqual(internals.hasSpellingMarker(document, "welllcome"), false);
and
shouldBecomeEqual(internals.hasSpellingMarker(document, "welcome"), false);

which makes shouldBecomeEqual unreliable.

I tried to describe this in the commit-msg.

 }
 
 function shouldBecomeEqualToString(value, reference, completionHandler, timeout)
@@ -411,7 +411,7 @@ function shouldBecomeDifferent(_a, _b, _completionHandler, _timeout)
     _timeout = 500;
 
   var _bv;
-  var _condition = function() {
+  function _condition() {
     var _exception;
     var _av;
     try {
@@ -433,7 +433,7 @@ function shouldBecomeDifferent(_a, _b, _completionHandler, _timeout)
     testFailed(_a + " did not become different from " + _bv + " in " + (_timeout / 1000) + " seconds.");
     _completionHandler();
   };
-  _waitForCondition(_condition, _failureTime, _completionHandler, _failureHandler);
+  setTimeout(_waitForCondition, 5, _condition, _failureTime, _completionHandler, _failureHandler);
 }
 
 function shouldBeTrue(a, quiet) { shouldBe(a, "true", quiet); }