shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value

LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html

Index: LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
diff --git a/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html b/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
index 65defdd5bdd58b0794755b7e0f76c3ffc8183aa5..f59d35405b8c81655e8ef5eb09c8666adb320f6b 100644
--- a/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
+++ b/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html
@@ -27,14 +27,15 @@ document.execCommand("InsertText", false, 'p');
 document.execCommand("InsertText", false, 'p');
 document.execCommand("InsertText", false, 'l');
 document.execCommand("InsertText", false, 'e');
-shouldBecomeEqual('internals.hasSpellingMarker(document, 0, 2)', 'true', function() {});
-window.getSelection().selectAllChildren(srcNode);
-document.execCommand('Copy');
+shouldBecomeEqual('internals.hasSpellingMarker(document, 0, 2)', 'true', function() {

[please use gerrit instead, 2015/02/10 22:57:50]

If this fixes flakiness, then you should separate this change into a separate
patch.

[grzegorz, 2015/02/11 10:54:23]

Since shouldBecomeEqual() now works asynchronously, we have to call the next
checking in its completion handler. Otherwise the test will finish earlier than
result of second shouldBecmeEqual() request.

It's strongly related to this CL.

+    window.getSelection().selectAllChildren(srcNode);
+    document.execCommand('Copy');
 
-internals.setContinuousSpellCheckingEnabled(false);
+    internals.setContinuousSpellCheckingEnabled(false);
 
-document.execCommand('Paste');
-shouldBecomeDifferent('internals.hasSpellingMarker(document, 0, 2)', 'true', finishJSTest);
+    document.execCommand('Paste');
+    shouldBecomeDifferent('internals.hasSpellingMarker(document, 0, 2)', 'true', finishJSTest);
+});
 
 </script>
 </body>