LayoutTests/resources-tests/should-become-equal-test.html - Issue 906193003: shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/resources-tests/should-become-equal-test.html

Issue 906193003: shouldBecomeEqual() behaves as shouldBe() if the testing expression returns the expected value Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add regression test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/spelling/spellcheck-paste-disabled.html ('k') | LayoutTests/resources-tests/should-become-equal-test-expected.txt » ('j') | LayoutTests/resources/js-test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	yosin_UTC9 2016/09/01 01:49:06 Could you use w3c test harness to test \|shouldBeco Could you use w3c test harness to test \|shouldBecomeEqual()\|? https://github.com/w3c/testharness.js/blob/master/docs/api.md BTW, ideal solution is using \|asyn_test()\| in w3c test harness. At this time there are 70 files using \|shouldBecomeEqual()\|, it is too far away to reach ideal world. :-<
	2 <body onload="runTest()">

	3 <script src="../resources/js-test.js"></script>

	4 <div id="testElement" contenteditable></div>

	5 <script>

	6 jsTestIsAsync = true;

	7

	8 description("This test verifies whether shouldBecomeEqual asynchronously "

	9 + "checks condition when testing expression returns the expected value.<br>"

	10 + "Otherwise, there will be no difference between:<br><br>"

	11 + "shouldBecomeEqual(internals.hasSpellingMarker(welllcome), false)<br> "

	12 + "shouldBecomeEqual(internals.hasSpellingMarker(welcome), false)<br>");

	13

	14 function runTest()

	15 {

	16 if (!window.internals)

	17 return;

	18

	19 internals.settings.setAsynchronousSpellCheckingEnabled(true);

	20 internals.settings.setUnifiedTextCheckerEnabled(true);

	21

	22 var testElement = document.getElementById("testElement");

	23 testElement.focus();

	24 document.execCommand("InsertText", false, "wellcome ");

	25 // Because async path of spellchecing is turned on it's unlikely to have

	26 // spelling markers at this point so that first call of hasSpellingMarker()

	27 // will probably return false and shouldBecomeEqual shouldn't report it as P ASS.

	28 shouldBecomeEqual("internals.hasSpellingMarker(document, 0, 8)", "false", fu nction() {
	please use gerrit instead 2015/02/17 16:28:48 You probably should not be testing shouldBecomeEqu You probably should not be testing shouldBecomeEqual() using the spellcheck code. Let's not make the utility code be dependent on spellcheck code. It should be other way around. Please define some other function in this file that can be tested using shouldBecomeEqual().
	29 testFailed("wellcome will have marker");

	30 finishJSTest();

	31 });

	32

	33 // We assume that the test passes if the test is not finished which means th at

	34 // shouldBecomeEqual's completion handler was not called.

	35 setTimeout(function() { fallback(10); }, 0);

	36 function fallback(nretry)

	37 {

	38 if (nretry)

	39 return setTimeout(function() { fallback(nretry - 1); }, 0);

	40 else {

	41 testPassed("");

	42 finishJSTest();

	43 }

	44 }

	45 }

	46 </script>

	47 </body>

	48 </html>

OLD	NEW