Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 906173005: Ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED for base unit tests. (Closed)

Created:
5 years, 10 months ago by rvargas (doing something else)
Modified:
5 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore FILE_ATTRIBUTE_NOT_CONTENT_INDEXED for base unit tests. FILE_ATTRIBUTE_NOT_CONTENT_INDEXED may or may not be set on a temp directory depending on the OS version and location of the directory. BUG=455470 Committed: https://crrev.com/8e197f924af30da5a799f133669ef64cf974c36f Cr-Commit-Position: refs/heads/master@{#315391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M base/files/file_util_unittest.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
I'm assuming we don't really need to enforce that temp is in a non_content_indexed path.
5 years, 10 months ago (2015-02-09 20:47:51 UTC) #2
M-A Ruel
lgtm
5 years, 10 months ago (2015-02-09 20:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906173005/1
5 years, 10 months ago (2015-02-09 20:58:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 21:02:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:03:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e197f924af30da5a799f133669ef64cf974c36f
Cr-Commit-Position: refs/heads/master@{#315391}

Powered by Google App Engine
This is Rietveld 408576698