Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 906153002: Add file_manager/video_player to Buildbot compilation. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add file_manager/video_player to Buildbot compilation. BUG=444485 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/8533a5153222d72c6f5485581663db13f285bfaf Cr-Commit-Position: refs/heads/master@{#315255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-09 01:43:44 UTC) #2
fukino
On 2015/02/09 01:43:44, yawano wrote: > PTAL. Thank you! lgtm
5 years, 10 months ago (2015-02-09 02:06:14 UTC) #3
yawano
On 2015/02/09 02:06:14, fukino wrote: > On 2015/02/09 01:43:44, yawano wrote: > > PTAL. Thank ...
5 years, 10 months ago (2015-02-09 02:06:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906153002/1
5 years, 10 months ago (2015-02-09 02:07:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 02:24:51 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 02:25:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8533a5153222d72c6f5485581663db13f285bfaf
Cr-Commit-Position: refs/heads/master@{#315255}

Powered by Google App Engine
This is Rietveld 408576698