Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 906123002: Change the order of insertion points which are involved in a re-distribution in event path (Closed)

Created:
5 years, 10 months ago by kojii
Modified:
5 years, 6 months ago
Reviewers:
hayato
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change the order of insertion points which are involved in a re-distribution in event path This patch changes the event path calculation algorithm[1] to a new proposed algorithm defined in a PR[2], which gives more natural order when re-distribution occurs. For further background of the change, refer to W3C bug 23887[3]. [1] http://w3c.github.io/webcomponents/spec/shadow/#dfn-event-path-calculation-algorithm [2] https://github.com/w3c/webcomponents/pull/42 [3] https://www.w3.org/Bugs/Public/show_bug.cgi?id=23887

Patch Set 1 #

Patch Set 2 : WIP, still experimental #

Patch Set 3 : event-path-spec-example.html #

Patch Set 4 : Intended changes in test results updated #

Patch Set 5 : Comment 169 of https://www.w3.org/Bugs/Public/show_bug.cgi?id=23887#c169 #

Patch Set 6 : After talked with Olli #

Patch Set 7 : #

Patch Set 8 : Fix ASSERT updateDistribution() #

Patch Set 9 : Rebase #

Patch Set 10 : Fix ASSERT updateDistribution() #

Patch Set 11 : fast/dom/click-method-on-html-element.html #

Patch Set 12 : reset-result 2 more tests after reviewing results #

Patch Set 13 : reset-result fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots.html #

Patch Set 14 : Moved updateDistribution to InspectorCSSAgent::getMatchedStylesForNode #

Patch Set 15 : Remove InspectorCSSAgent (no longer AF) #

Patch Set 16 : Rebase+editorial changes #

Patch Set 17 : Minor fix #

Patch Set 18 : Candidate 2 #

Patch Set 19 : Candidate 2 cleanup #

Patch Set 20 : For review, remove all #ifdef etc. #

Patch Set 21 : "hayato-2015-04" algorithm #

Patch Set 22 : test updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -40 lines) Patch
A LayoutTests/fast/dom/shadow/event-path-algorithm.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +109 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-in-shadow-tree-expected.txt View 1 2 3 9 10 11 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-with-dom-mutation-expected.txt View 1 2 3 9 10 11 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt View 1 2 3 9 10 11 12 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/events/EventPath.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 6 chunks +239 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kojii
It's still WIP and experimental, but if you see any apparent mistakes, that's appreciated.
5 years, 10 months ago (2015-02-10 04:43:27 UTC) #2
kojii
Added the example in the spec, and got the expected result as described in https://www.w3.org/Bugs/Public/show_bug.cgi?id=23887#c124 ...
5 years, 10 months ago (2015-02-10 07:36:57 UTC) #3
kojii
PS4 resets test results where diffs are intentional changes, leaving 4 tests to review more ...
5 years, 10 months ago (2015-02-12 07:53:38 UTC) #4
kojii
PTAL.
5 years, 8 months ago (2015-04-17 07:14:59 UTC) #14
kojii
5 years, 6 months ago (2015-06-05 01:53:46 UTC) #15
Closing, as we've abandoned this plan.

Powered by Google App Engine
This is Rietveld 408576698